From: Pavel Begunkov <asml.silence@gmail.com>
To: Bijan Mottahedeh <bijan.mottahedeh@oracle.com>, axboe@kernel.dk
Cc: io-uring@vger.kernel.org
Subject: Re: [RFC 1/1] io_uring: preserve work->mm since actual work processing may need it
Date: Fri, 10 Apr 2020 20:57:29 +0300 [thread overview]
Message-ID: <a36ec903-c740-2bb3-ab97-890757c290ee@gmail.com> (raw)
In-Reply-To: <dbcf7351-aba2-a64e-ecd9-26666b30469f@gmail.com>
On 10/04/2020 20:51, Pavel Begunkov wrote:
>> I added an assert in do_madvise() for a NULL mm value and hit it running the test.
>>
>>> What tree do you use? Extra patches on top?
>>
>> I'm using next-20200409 with no patches.
>
> I see, it came from 676a179 ("mm: pass task and mm to do_madvise"), which isn't
> in Jen's tree
oops, sorry for mistyping your name.
>
> I don't think your patch will do, because it changes mm refcounting with extra
> mmdrop() in io_req_work_drop_env(). That's assuming it worked well before.
>
> Better fix then is to make it ```do_madvise(NULL, current->mm, ...)```
> as it actually was at some point in the mentioned patch (v5).
Jens, how this should be handled? Through what tree it has to go?
--
Pavel Begunkov
next prev parent reply other threads:[~2020-04-10 17:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 22:03 [RFC 0/1] io_uring: preserve work->mm since actual work processing may need it Bijan Mottahedeh
2020-04-09 22:03 ` [RFC 1/1] " Bijan Mottahedeh
2020-04-10 8:47 ` Pavel Begunkov
2020-04-10 16:54 ` Bijan Mottahedeh
2020-04-10 17:51 ` Pavel Begunkov
2020-04-10 17:57 ` Pavel Begunkov [this message]
2020-04-10 19:09 ` Bijan Mottahedeh
2020-04-11 2:17 ` Jens Axboe
2020-04-16 20:24 ` Minchan Kim
2020-04-16 20:30 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a36ec903-c740-2bb3-ab97-890757c290ee@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=bijan.mottahedeh@oracle.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).