From: Jens Axboe <axboe@kernel.dk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: io-uring <io-uring@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] io_uring updates for 5.10-rc1
Date: Tue, 13 Oct 2020 13:49:01 -0600 [thread overview]
Message-ID: <a81737e4-44da-cffc-cba0-8aec984df240@kernel.dk> (raw)
In-Reply-To: <CAHk-=wgUjjxhe2qREhdDm5VYYmLJWG2e_-+rgChf1aBkBqmtHw@mail.gmail.com>
On 10/13/20 1:46 PM, Linus Torvalds wrote:
> On Mon, Oct 12, 2020 at 6:46 AM Jens Axboe <axboe@kernel.dk> wrote:
>>
>> Here are the io_uring updates for 5.10.
>
> Very strange. My clang build gives a warning I've never seen before:
>
> /tmp/io_uring-dd40c4.s:26476: Warning: ignoring changed section
> attributes for .data..read_mostly
>
> and looking at what clang generates for the *.s file, it seems to be
> the "section" line in:
>
> .type io_op_defs,@object # @io_op_defs
> .section .data..read_mostly,"a",@progbits
> .p2align 4
>
> I think it's the combination of "const" and "__read_mostly".
>
> I think the warning is sensible: how can a piece of data be both
> "const" and "__read_mostly"? If it's "const", then it's not "mostly"
> read - it had better be _always_ read.
>
> I'm letting it go, and I've pulled this (gcc doesn't complain), but
> please have a look.
Huh weird, I'll take a look. FWIW, the construct isn't unique across
the kernel.
What clang are you using?
--
Jens Axboe
next prev parent reply other threads:[~2020-10-13 19:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 13:46 [GIT PULL] io_uring updates for 5.10-rc1 Jens Axboe
2020-10-13 19:46 ` Linus Torvalds
2020-10-13 19:49 ` Jens Axboe [this message]
2020-10-13 19:50 ` Linus Torvalds
2020-10-13 20:49 ` Rasmus Villemoes
2020-10-13 21:00 ` Jens Axboe
2020-10-13 21:06 ` Arvind Sankar
2020-10-14 17:43 ` Nick Desaulniers
2020-10-13 19:47 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a81737e4-44da-cffc-cba0-8aec984df240@kernel.dk \
--to=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).