IO-Uring Archive on lore.kernel.org
 help / color / Atom feed
* Re: [RFC PATCH] io-wq: kill cpu hog worker
       [not found] <20191223024145.11580-1-hdanton@sina.com>
@ 2019-12-23 15:15 ` Jens Axboe
       [not found] ` <20191224115415.1360-1-hdanton@sina.com>
  1 sibling, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2019-12-23 15:15 UTC (permalink / raw)
  To: Hillf Danton, io-uring; +Cc: viro, linux-fsdevel, linux-kernel, linux-mm

On 12/22/19 7:41 PM, Hillf Danton wrote:
> 
> Reschedule the current IO worker if it is becoming a cpu hog.

Might make more sense to put this a bit earlier, to avoid the
awkward lock juggle. In theory it shouldn't make a difference
if we do it _before_ doing new work, or _after_ doing work. We
should only be rescheduling if it's running for quite a while.

How about putting it after the flushing of signals instead?

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [RFC PATCH] io-wq: kill cpu hog worker
       [not found] ` <20191224115415.1360-1-hdanton@sina.com>
@ 2019-12-24 16:13   ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2019-12-24 16:13 UTC (permalink / raw)
  To: Hillf Danton; +Cc: io-uring, viro, linux-fsdevel, linux-kernel, linux-mm

On 12/24/19 4:54 AM, Hillf Danton wrote:
> 
> On Mon, 23 Dec 2019 08:15:00 -0700 Jens Axboe wrote:
>>
>> On 12/22/19 7:41 PM, Hillf Danton wrote:
>>>
>>> Reschedule the current IO worker if it is becoming a cpu hog.
>>
>> Might make more sense to put this a bit earlier, to avoid the
>> awkward lock juggle. In theory it shouldn't make a difference
>> if we do it _before_ doing new work, or _after_ doing work. We
>> should only be rescheduling if it's running for quite a while.
>>
>> How about putting it after the flushing of signals instead?
> 
> 
> All right, thanks.
> 
> Hillf
> --->8---
> From: Hillf Danton <hdanton@sina.com>
> Subject: [RFC PATCH] io-wq: kill cpu hog worker
> 
> Reschedule the current IO worker to cut the risk that it is becoming
> a cpu hog.
> 
> Signed-off-by: Hillf Danton <hdanton@sina.com>
> ---
> 
> --- a/fs/io-wq.c
> +++ b/fs/io-wq.c
> @@ -432,6 +432,8 @@ next:
>  		if (signal_pending(current))
>  			flush_signals(current);
>  
> +		cond_resched();
> +
>  		spin_lock_irq(&worker->lock);
>  		worker->cur_work = work;
>  		spin_unlock_irq(&worker->lock);
> --

That looks better, applied.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20191223024145.11580-1-hdanton@sina.com>
2019-12-23 15:15 ` [RFC PATCH] io-wq: kill cpu hog worker Jens Axboe
     [not found] ` <20191224115415.1360-1-hdanton@sina.com>
2019-12-24 16:13   ` Jens Axboe

IO-Uring Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/io-uring/0 io-uring/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 io-uring io-uring/ https://lore.kernel.org/io-uring \
		io-uring@vger.kernel.org
	public-inbox-index io-uring

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.io-uring


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git