IO-Uring Archive on
 help / color / Atom feed
From: Pavel Begunkov <>
To: Jens Axboe <>, io-uring <>
Subject: Re: io_close()
Date: Sat, 8 Feb 2020 00:35:26 +0300
Message-ID: <> (raw)
In-Reply-To: <>

[-- Attachment #1.1: Type: text/plain, Size: 711 bytes --]

On 08/02/2020 00:14, Jens Axboe wrote:
> On 2/7/20 1:52 PM, Pavel Begunkov wrote:
>> Hi,
>> I noticed, that io_close() is broken for some use cases, and was thinking about
>> the best way to fix it. Is fput(req->close.put_file) really need to be done in
>> wq? It seems, fput_many() implementation just calls schedule_delayed_work(), so
>> it's already delayed.
> It's not the fput(), it's the f_op->flush().

What confuses me, is that in case of ->flush, it doesn't return -EAGAIN, but
io_queue_async_work() itself, so nobody will set ->work.files. But that means
io_close_finish() won't do filp_close() as well.

Did I missed somewhere called io_grab_files()?

Pavel Begunkov

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      parent reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-07 20:52 io_close() Pavel Begunkov
2020-02-07 21:14 ` io_close() Jens Axboe
2020-02-07 21:19   ` io_close() Pavel Begunkov
2020-02-07 21:35   ` Pavel Begunkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

IO-Uring Archive on

Archives are clonable:
	git clone --mirror io-uring/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 io-uring io-uring/ \
	public-inbox-index io-uring

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone