From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>, io-uring@vger.kernel.org
Subject: Re: [PATCH 1/1] io_uring: fix link timeout refs
Date: Sat, 8 May 2021 22:12:14 -0600 [thread overview]
Message-ID: <cbc5ae0e-8c1f-aa32-ee94-2f65788abbe5@kernel.dk> (raw)
In-Reply-To: <ff51018ff29de5ffa76f09273ef48cb24c720368.1620417627.git.asml.silence@gmail.com>
On 5/7/21 2:06 PM, Pavel Begunkov wrote:
> WARNING: CPU: 0 PID: 10242 at lib/refcount.c:28 refcount_warn_saturate+0x15b/0x1a0 lib/refcount.c:28
> RIP: 0010:refcount_warn_saturate+0x15b/0x1a0 lib/refcount.c:28
> Call Trace:
> __refcount_sub_and_test include/linux/refcount.h:283 [inline]
> __refcount_dec_and_test include/linux/refcount.h:315 [inline]
> refcount_dec_and_test include/linux/refcount.h:333 [inline]
> io_put_req fs/io_uring.c:2140 [inline]
> io_queue_linked_timeout fs/io_uring.c:6300 [inline]
> __io_queue_sqe+0xbef/0xec0 fs/io_uring.c:6354
> io_submit_sqe fs/io_uring.c:6534 [inline]
> io_submit_sqes+0x2bbd/0x7c50 fs/io_uring.c:6660
> __do_sys_io_uring_enter fs/io_uring.c:9240 [inline]
> __se_sys_io_uring_enter+0x256/0x1d60 fs/io_uring.c:9182
>
> io_link_timeout_fn() should put only one reference of the linked timeout
> request, however in case of racing with the master request's completion
> first io_req_complete() puts one and then io_put_req_deferred() is
> called.
Applied, thanks.
--
Jens Axboe
next prev parent reply other threads:[~2021-05-09 4:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 20:06 [PATCH 1/1] io_uring: fix link timeout refs Pavel Begunkov
2021-05-09 4:12 ` Jens Axboe [this message]
2021-06-12 12:09 ` Martin Raiber
2021-06-15 13:39 ` Pavel Begunkov
2021-08-08 9:00 ` Martin Raiber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbc5ae0e-8c1f-aa32-ee94-2f65788abbe5@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).