archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <>
To: Xiaoguang Wang <>,
Subject: Re: [PATCH] io_uring: fix missing sigmask restore in io_cqring_wait()
Date: Tue, 14 Sep 2021 08:47:52 -0600	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 9/14/21 8:38 AM, Xiaoguang Wang wrote:
> Move get_timespec() section in io_cqring_wait() before the sigmask
> saving, otherwise we'll fail to restore sigmask once get_timespec()
> returns error.

Applied, thanks! I added a:

Fixes: c73ebb685fb6 ("io_uring: add timeout support for io_uring_enter()")

to the commit since that's when it got broken, that'll help with
stable backports. Not that it's a _huge_ issue, it basically means
the application is broken anyway.

Jens Axboe

  reply	other threads:[~2021-09-14 14:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-14 14:38 [PATCH] io_uring: fix missing sigmask restore in io_cqring_wait() Xiaoguang Wang
2021-09-14 14:47 ` Jens Axboe [this message]
2021-09-14 14:53   ` Xiaoguang Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).