* [PATCH for-5.15 v2] io_uring: don't free request to slab
@ 2021-08-25 17:58 Hao Xu
2021-08-25 19:02 ` Pavel Begunkov
2021-08-25 19:05 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Hao Xu @ 2021-08-25 17:58 UTC (permalink / raw)
To: Jens Axboe; +Cc: io-uring, Pavel Begunkov, Joseph Qi
It's not necessary to free the request back to slab when we fail to
get sqe, just move it to state->free_list.
Signed-off-by: Hao Xu <haoxu@linux.alibaba.com>
---
fs/io_uring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/io_uring.c b/fs/io_uring.c
index 74b606990d7e..c53b084668fc 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -6899,7 +6899,7 @@ static int io_submit_sqes(struct io_ring_ctx *ctx, unsigned int nr)
}
sqe = io_get_sqe(ctx);
if (unlikely(!sqe)) {
- kmem_cache_free(req_cachep, req);
+ list_add(&req->inflight_entry, &ctx->submit_state.free_list);
break;
}
/* will complete beyond this point, count as submitted */
--
2.24.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH for-5.15 v2] io_uring: don't free request to slab
2021-08-25 17:58 [PATCH for-5.15 v2] io_uring: don't free request to slab Hao Xu
@ 2021-08-25 19:02 ` Pavel Begunkov
2021-08-25 19:05 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Pavel Begunkov @ 2021-08-25 19:02 UTC (permalink / raw)
To: Hao Xu, Jens Axboe; +Cc: io-uring, Joseph Qi
On 8/25/21 6:58 PM, Hao Xu wrote:
> It's not necessary to free the request back to slab when we fail to
> get sqe, just move it to state->free_list.
Looks good, with that we have a consistent behaviour of retaining
io_kiocb for all cases.
Reviewed-by: Pavel Begunkov <asml.silence@gmail.com>
> Signed-off-by: Hao Xu <haoxu@linux.alibaba.com>
> ---
> fs/io_uring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/io_uring.c b/fs/io_uring.c
> index 74b606990d7e..c53b084668fc 100644
> --- a/fs/io_uring.c
> +++ b/fs/io_uring.c
> @@ -6899,7 +6899,7 @@ static int io_submit_sqes(struct io_ring_ctx *ctx, unsigned int nr)
> }
> sqe = io_get_sqe(ctx);
> if (unlikely(!sqe)) {
> - kmem_cache_free(req_cachep, req);
> + list_add(&req->inflight_entry, &ctx->submit_state.free_list);
> break;
> }
> /* will complete beyond this point, count as submitted */
>
--
Pavel Begunkov
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH for-5.15 v2] io_uring: don't free request to slab
2021-08-25 17:58 [PATCH for-5.15 v2] io_uring: don't free request to slab Hao Xu
2021-08-25 19:02 ` Pavel Begunkov
@ 2021-08-25 19:05 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2021-08-25 19:05 UTC (permalink / raw)
To: Hao Xu; +Cc: io-uring, Pavel Begunkov, Joseph Qi
On 8/25/21 11:58 AM, Hao Xu wrote:
> It's not necessary to free the request back to slab when we fail to
> get sqe, just move it to state->free_list.
Thanks, applied.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-25 19:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-25 17:58 [PATCH for-5.15 v2] io_uring: don't free request to slab Hao Xu
2021-08-25 19:02 ` Pavel Begunkov
2021-08-25 19:05 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).