From: Pavel Begunkov <asml.silence@gmail.com>
To: Jens Axboe <axboe@kernel.dk>, io-uring@vger.kernel.org
Subject: [PATCH for-linus] io_uring: Fix getting file for timeout
Date: Thu, 14 Nov 2019 00:59:19 +0300 [thread overview]
Message-ID: <df7029d394c63cb6f5fcab9282f37e2caa033d94.1573681962.git.asml.silence@gmail.com> (raw)
In-Reply-To: <5b145d14-59e8-041e-9b8a-21ec1d71e082@gmail.com>
For timeout requests io_uring tries to grab a file with specified fd,
which is usually stdin/fd=0.
Update io_op_needs_file()
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
---
fs/io_uring.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/io_uring.c b/fs/io_uring.c
index f9a38998f2fc..9dfc6d8a2444 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -2283,6 +2283,7 @@ static bool io_op_needs_file(const struct io_uring_sqe *sqe)
switch (op) {
case IORING_OP_NOP:
case IORING_OP_POLL_REMOVE:
+ case IORING_OP_TIMEOUT:
return false;
default:
return true;
--
2.24.0
next prev parent reply other threads:[~2019-11-13 21:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 21:11 [PATCH] io_uring: Fix getting file for timeout Pavel Begunkov
2019-11-13 21:33 ` Jens Axboe
2019-11-13 21:37 ` Jens Axboe
2019-11-13 21:47 ` Pavel Begunkov
2019-11-13 21:54 ` Jens Axboe
2019-11-13 22:05 ` Pavel Begunkov
2019-11-13 22:27 ` Jens Axboe
2019-11-13 21:59 ` Pavel Begunkov [this message]
2019-11-13 21:59 ` [PATCH for-5.5] io_uring: update io_op_needs_file Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df7029d394c63cb6f5fcab9282f37e2caa033d94.1573681962.git.asml.silence@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).