From: Jens Axboe <axboe@kernel.dk>
To: Dylan Yudaken <dylany@fb.com>, Pavel Begunkov <asml.silence@gmail.com>
Cc: io-uring@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [PATCH 0/3] io_uring: register single issuer task at creation
Date: Mon, 26 Sep 2022 08:37:53 -0600 [thread overview]
Message-ID: <e1ddd430-384d-f704-2373-41a455288380@kernel.dk> (raw)
In-Reply-To: <20220926140304.1973990-1-dylany@fb.com>
On 9/26/22 8:03 AM, Dylan Yudaken wrote:
> Registering the single issuer task from the first submit adds unnecesary
> complications to the API as well as the implementation. Where simply
> registering it at creation should not impose any barriers to getting the
> same performance wins.
>
> There is another problem in 6.1, with IORING_SETUP_DEFER_TASKRUN. That
> would like to check the submitter_task from unlocked contexts, which would
> be racy. If upfront the submitter_task is set at creation time it will
> simplify the logic there and probably increase performance (though this is
> unmeasured).
>
> Patch 1 registers the task at creation of the io_uring, this works
> standalone in case you want to only merge this part for 6.0
>
> Patch 2/3 cleans up the code from the old style
Applied 1/3 for 6.0, and then created a new branch for 6.1 that holds
2-3/3. Thanks!
--
Jens Axboe
prev parent reply other threads:[~2022-09-26 15:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 14:03 [PATCH 0/3] io_uring: register single issuer task at creation Dylan Yudaken
2022-09-26 14:03 ` [PATCH 1/3] " Dylan Yudaken
2022-09-26 14:03 ` [PATCH 2/3] io_uring: simplify __io_uring_add_tctx_node Dylan Yudaken
2022-09-26 14:03 ` [PATCH 3/3] io_uring: remove io_register_submitter Dylan Yudaken
2022-09-26 14:37 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1ddd430-384d-f704-2373-41a455288380@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=dylany@fb.com \
--cc=io-uring@vger.kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).