From: Jens Axboe <axboe@kernel.dk>
To: Colin King <colin.king@canonical.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] io_uring: fix return of an uninitialized variable ret
Date: Tue, 11 Feb 2020 09:07:11 -0700 [thread overview]
Message-ID: <e293c9a0-af86-d2f9-7ee7-c5ac41370887@kernel.dk> (raw)
In-Reply-To: <20200211160259.90660-1-colin.king@canonical.com>
On 2/11/20 9:02 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently variable ret is not initialized and this value is being
> returned at the end of the function io_poll_double_wake. Since
> ret is not being used anywhere else remove it and just return 0.
It's supposed to return 1, a previous edition had 'ret' dependent
on the wake call, but we didn't need that anymore.
I folded in a fix earlier this morning, and my for-next branch should
now be fine.
--
Jens Axboe
prev parent reply other threads:[~2020-02-11 16:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 16:02 [PATCH][next] io_uring: fix return of an uninitialized variable ret Colin King
2020-02-11 16:07 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e293c9a0-af86-d2f9-7ee7-c5ac41370887@kernel.dk \
--to=axboe@kernel.dk \
--cc=colin.king@canonical.com \
--cc=io-uring@vger.kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).