From: Jens Axboe <axboe@kernel.dk>
To: Eli Schwartz <eschwartz93@gmail.com>,
Ammar Faizi <ammarfaizi2@gnuweeb.org>,
Pavel Begunkov <asml.silence@gmail.com>
Cc: io-uring Mailing List <io-uring@vger.kernel.org>
Subject: Re: [PATCH liburing 3/4] tests: add tests for zerocopy send and notifications
Date: Mon, 25 Jul 2022 17:37:03 -0600 [thread overview]
Message-ID: <eb9f8e37-a3b5-0b87-4f90-7ec80772e3fb@kernel.dk> (raw)
In-Reply-To: <7f146700-ad7a-08b2-ecb8-c88d4f57a8eb@gmail.com>
On 7/25/22 12:55 PM, Eli Schwartz wrote:
> T_EXIT_ERROR is different. It doesn't mean the test ran, and reported
> something wrong with the software (e.g. liburing). Instead, an ERROR
> return value indicates that the test itself broke and cannot even be
> relied on to accurately test for a bug/regression. For example, if that
> test was designated as an expected failure, it still knows that in this
> case, error != fail, and it won't ignore the result as an expected failure.
>
> Also in general, if you see test errors you know to look at bugs in the
> testsuite instead of trying to debug the software. :)
>
> I added T_EXIT_ERROR because it may be useful, without knowing in
> advance whether I would have cause to use it anywhere. It's a valid
> possible state.
I think we should kill that, it just causes confusion and I generally
hate adding infrastructure that isn't even being used. Besides, I don't
see it being useful at all. Yes, tests could eg return T_EXIT_ERROR if
io_uring_get_sqe() return NULL and it should not have. In reality,
that's just a test failure and you need to look into why that happened
anyway.
As such, I don't think it's a useful distinction at all. Nobody is ever
going to be writing tests and be making that distinction.
--
Jens Axboe
next prev parent reply other threads:[~2022-07-25 23:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 10:03 [PATCH liburing 0/4] zerocopy send headers and tests Pavel Begunkov
2022-07-25 10:03 ` [PATCH liburing 1/4] io_uring.h: sync with kernel for zc send and notifiers Pavel Begunkov
2022-07-25 10:03 ` [PATCH liburing 2/4] liburing: add zc send and notif helpers Pavel Begunkov
2022-07-25 10:20 ` Ammar Faizi
2022-07-25 11:18 ` Pavel Begunkov
2022-07-25 10:03 ` [PATCH liburing 3/4] tests: add tests for zerocopy send and notifications Pavel Begunkov
2022-07-25 10:35 ` Ammar Faizi
2022-07-25 11:28 ` Pavel Begunkov
2022-07-25 12:08 ` Ammar Faizi
2022-07-25 14:07 ` Pavel Begunkov
2022-07-25 18:55 ` Eli Schwartz
2022-07-25 23:37 ` Jens Axboe [this message]
2022-07-26 9:35 ` Ammar Faizi
2022-07-25 10:03 ` [PATCH liburing 4/4] examples: add a zerocopy send example Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb9f8e37-a3b5-0b87-4f90-7ec80772e3fb@kernel.dk \
--to=axboe@kernel.dk \
--cc=ammarfaizi2@gnuweeb.org \
--cc=asml.silence@gmail.com \
--cc=eschwartz93@gmail.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).