From: Jens Axboe <axboe@kernel.dk>
To: Chucheng Luo <luochucheng@vivo.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: kernel@vivo.com
Subject: Re: [PATCH] io_uring:fix missing 'return' in comment
Date: Tue, 24 Mar 2020 21:48:25 -0600 [thread overview]
Message-ID: <ee9047e5-c18e-4f41-e45a-0c5e963787f8@kernel.dk> (raw)
In-Reply-To: <20200325033138.21488-1-luochucheng@vivo.com>
On 3/24/20 9:31 PM, Chucheng Luo wrote:
> the missing 'return' work may make it hard
> for other developers to understand it.
Thanks, that does read better. Notes for future patches:
- You should capitalize the first letter in the commit message,
any sentence really.
- Commit messages should use 72-74 chars of line width
- Add a space after 'io_uring:' and title description
I fixed these up and hand applied to for-5.7/io_uring.
--
Jens Axboe
prev parent reply other threads:[~2020-03-25 3:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 3:31 [PATCH] io_uring:fix missing 'return' in comment Chucheng Luo
2020-03-25 3:48 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee9047e5-c18e-4f41-e45a-0c5e963787f8@kernel.dk \
--to=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=kernel@vivo.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luochucheng@vivo.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).