From: Jens Axboe <axboe@kernel.dk>
To: Jackie Liu <liuyun01@kylinos.cn>
Cc: io-uring@vger.kernel.org
Subject: Re: [PATCH v2] io_uring: add support for linked SQE timeouts
Date: Thu, 7 Nov 2019 19:12:33 -0700 [thread overview]
Message-ID: <f5930ec1-d3b3-4cd9-0648-fa835b347318@kernel.dk> (raw)
In-Reply-To: <C0C26DA7-DD02-46EE-A398-51A50962A724@kylinos.cn>
On 11/7/19 6:24 PM, Jackie Liu wrote:
>> @@ -734,11 +755,23 @@ static void io_req_link_next(struct io_kiocb *req, struct io_kiocb **nxtptr)
>> * If we're in async work, we can continue processing the chain
>> * in this context instead of having to queue up new async work.
>> */
>> - if (nxtptr && current_work())
>> + if (req->flags & REQ_F_LINK_TIMEOUT) {
>> + wake_ev = io_link_cancel_timeout(ctx, nxt);
>> +
>> + /* we dropped this link, get next */
>> + nxt = list_first_entry_or_null(&req->link_list,
>> + struct io_kiocb, list);
>> + } else if (nxtptr && current_work()) {
>> *nxtptr = nxt;
>> - else
>> + nxt = NULL;
>
> Use 'break' is more better? no need to set variables and compare.
Fine with me, I'll make that change. Happy with it otherwise?
--
Jens Axboe
prev parent reply other threads:[~2019-11-08 2:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 2:05 [PATCH v2] io_uring: add support for linked SQE timeouts Jens Axboe
2019-11-08 1:24 ` Jackie Liu
2019-11-08 2:12 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5930ec1-d3b3-4cd9-0648-fa835b347318@kernel.dk \
--to=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=liuyun01@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).