io-uring.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Yin Fengwei <fengwei.yin@intel.com>,
	kernel test robot <oliver.sang@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	io-uring@vger.kernel.org, lkp@lists.01.org, lkp@intel.com
Subject: Re: [LKP] Re: [io_uring] 584b0180f0: phoronix-test-suite.fio.SequentialWrite.IO_uring.Yes.Yes.1MB.DefaultTestDirectory.mb_s -10.2% regression
Date: Wed, 20 Jul 2022 11:24:14 -0600	[thread overview]
Message-ID: <f5d20f6c-5363-231b-b208-b577a59b4ae9@kernel.dk> (raw)
In-Reply-To: <2ec953da-78fd-df01-44cf-6f33a5e40864@intel.com>

On 7/19/22 2:58 AM, Yin Fengwei wrote:
> Hi Jens,
> 
> On 7/19/2022 10:29 AM, Jens Axboe wrote:
>> I'll poke at this tomorrow.
> 
> Just FYI. Another finding (test is based on commit 584b0180f0):
> If the code block is put to different function, the fio performance result is
> different:

I think this turned out to be a little bit of a goose chase. What's
happening here is that later kernels defer the file assignment, which
means it isn't set if a request is queued with IOSQE_ASYNC. That in
turn, for writes, means that we don't hash it on io-wq insertion, and
then it doesn't get serialized with other writes to that file.

I'll come up with a patch for this that you can test.

-- 
Jens Axboe


  reply	other threads:[~2022-07-20 17:24 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220527092432.GE11731@xsang-OptiPlex-9020>
2022-05-27 13:50 ` [io_uring] 584b0180f0: phoronix-test-suite.fio.SequentialWrite.IO_uring.Yes.Yes.1MB.DefaultTestDirectory.mb_s -10.2% regression Jens Axboe
2022-06-08  8:00   ` Oliver Sang
2022-06-14  1:54   ` [LKP] " Yin Fengwei
2022-07-12  8:06   ` Yin Fengwei
2022-07-15 15:58     ` Jens Axboe
2022-07-18  0:58       ` Yin Fengwei
2022-07-18  1:14         ` Jens Axboe
2022-07-18  3:30       ` Yin Fengwei
2022-07-18 16:27         ` Jens Axboe
2022-07-19  0:27           ` Yin Fengwei
2022-07-19  2:16           ` Yin Fengwei
2022-07-19  2:29             ` Jens Axboe
2022-07-19  8:58               ` Yin Fengwei
2022-07-20 17:24                 ` Jens Axboe [this message]
2022-07-20 18:13                   ` Jens Axboe
2022-07-20 23:25                     ` Yin Fengwei
2022-07-21  2:59                     ` Yin Fengwei
2022-07-21  3:08                   ` Yin Fengwei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f5d20f6c-5363-231b-b208-b577a59b4ae9@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=fengwei.yin@intel.com \
    --cc=io-uring@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=lkp@lists.01.org \
    --cc=oliver.sang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).