io-uring.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>, io-uring@vger.kernel.org
Cc: Dave Jones <davej@codemonkey.org.uk>
Subject: Re: [PATCH] io_uring: kill extra checks in io_write()
Date: Fri, 24 Sep 2021 10:26:24 -0600	[thread overview]
Message-ID: <f9be7854-449f-5891-d820-b558d9dd5434@kernel.dk> (raw)
In-Reply-To: <5b33e61034748ef1022766efc0fb8854cfcf749c.1632500058.git.asml.silence@gmail.com>

On 9/24/21 10:14 AM, Pavel Begunkov wrote:
> We don't retry short writes and so we would never get to async setup in
> io_write() in that case. Thus ret2 > 0 is always false and
> iov_iter_advance() is never used. Apparently, the same is found by
> Coverity, which complains on the code.

Thanks, applied. Should have a:

Fixes: cd65869512ab ("io_uring: use iov_iter state save/restore helpers")

which I added.

-- 
Jens Axboe


      reply	other threads:[~2021-09-24 16:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-24 16:14 [PATCH] io_uring: kill extra checks in io_write() Pavel Begunkov
2021-09-24 16:26 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f9be7854-449f-5891-d820-b558d9dd5434@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=asml.silence@gmail.com \
    --cc=davej@codemonkey.org.uk \
    --cc=io-uring@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).