From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C86E5C433DF for ; Thu, 15 Oct 2020 13:12:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5DE9A22269 for ; Thu, 15 Oct 2020 13:12:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="TMPDsFEY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728884AbgJONMU (ORCPT ); Thu, 15 Oct 2020 09:12:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728820AbgJONMT (ORCPT ); Thu, 15 Oct 2020 09:12:19 -0400 Received: from mail-il1-x131.google.com (mail-il1-x131.google.com [IPv6:2607:f8b0:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 621C2C0613D2 for ; Thu, 15 Oct 2020 06:12:18 -0700 (PDT) Received: by mail-il1-x131.google.com with SMTP id j8so4034311ilk.0 for ; Thu, 15 Oct 2020 06:12:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=JrQAp+G/w/HRcUvrALtAjr5XUD+f148osx1+XDbx/fQ=; b=TMPDsFEY6QcbJz9eph5zwMwK3REFYpu/Kf99wKKHvUNjeCFeqY6R4mTOZY23moUy26 rurYaAvGUoHOtOoW+PHtt5/hXy+/j9VbDMicj8j+TyBnkBB20/J6FDtPRzgBNL49uuyw CWKU3iFSYQLEpKIJCE9vhLrdWLv518JmrDHPkYRnHhJBJYn3KupmFAlwk8OHpWXg1sQB RMd0Ynbr9DG5O4vK98dJCSYrY1ArHTTIYOflX4lx35q3XLYxiaTm27ZFwkr6UDSxjlK8 92zMXuTRKuoSztsTjE3N0yJfnq4Jk7d7yGtKXx3fLeZqjL3rnL6PRpSFH9Cnynkba7fP W4eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JrQAp+G/w/HRcUvrALtAjr5XUD+f148osx1+XDbx/fQ=; b=LvmfdGPBo1G3txGnNYW3zH2HkCSjX3PCPhf2BgJzlp1FBsUB+rJ85fW9zpJTNe7eUK 4q4loikWhAhIG93EBwvOMEvqThi6QJ3fNZN869CWj5jxvdSUtG3gXjUv7mj52sZbFiH+ mIFCfbsFTeUnF/96Jm2Q/zj33b/EzRD6MlJmTYKXt9p+ykmdCNDacpB2KJLYCKk7nsgf R7eKP5PLkBW7WnORCtijocEZA16Ofogl4QoiyOEol56GHftT7s9cRipcDLW47YsCo9hi 1pznS/6tIGkR1k9cBrv7zGUoYIImryYlcbPIWDO9GIdUo2uTJpp8y39x/bDy/NSxWoqh CWWQ== X-Gm-Message-State: AOAM530c1VluALEIHFE01MzZxDMABeEWoP09EFcMdDMej8RnQiaEf2N0 czLkXlox+ZcidSDVeh4squcebA== X-Google-Smtp-Source: ABdhPJzckRjsyjtt2YkhjIXx9g5RUmeO3YBn9nUW/Tceos9xwTtJgiku1z+klmtZupOu/z8YA1c/QQ== X-Received: by 2002:a92:7742:: with SMTP id s63mr833462ilc.74.1602767537685; Thu, 15 Oct 2020 06:12:17 -0700 (PDT) Received: from [192.168.1.30] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id h125sm793569iof.53.2020.10.15.06.12.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Oct 2020 06:12:17 -0700 (PDT) Subject: Re: [PATCH][next] io_uring: fix flags check for the REQ_F_WORK_INITIALIZED setting To: Colin King , Alexander Viro , Pavel Begunkov , linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20201015115550.485235-1-colin.king@canonical.com> From: Jens Axboe Message-ID: Date: Thu, 15 Oct 2020 07:12:16 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201015115550.485235-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 10/15/20 5:55 AM, Colin King wrote: > From: Colin Ian King > > Currently the check for REQ_F_WORK_INITIALIZED is always true because > the | operator is being used. I believe this check should be checking > if the bit is set using the & operator. It should - I folded in the incremental from Pavel. This just meant that we took the slow and safe path, but it obviously should be an AND here. -- Jens Axboe