From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E952AC433DF for ; Mon, 17 Aug 2020 20:55:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BBEBF2053B for ; Mon, 17 Aug 2020 20:55:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ixmk7aXV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726977AbgHQUz1 (ORCPT ); Mon, 17 Aug 2020 16:55:27 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:29339 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726228AbgHQUz0 (ORCPT ); Mon, 17 Aug 2020 16:55:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597697725; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/W0oK1YUXP87/SYW7b0oD+q5JT2V86VwEMcbp2m3c5c=; b=ixmk7aXVCdZ4BFiXYX/5ZJHEvDZ997I+hRPD84yzqCh8voo/OHo0goYyAdquP+u55u2SUF K1bZIHDhyNzd/hPiSgG7pscCleQ52oed0TPs3Z5pCeP7U59+1Ikg971dTZiA+ne3WuHOUD Y1XIvJv5WRNqhWQHB5DCtfh9msKyspQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-261-COPhEeFENhqcuaUHal3K5Q-1; Mon, 17 Aug 2020 16:55:23 -0400 X-MC-Unique: COPhEeFENhqcuaUHal3K5Q-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 64A8181F007; Mon, 17 Aug 2020 20:55:21 +0000 (UTC) Received: from segfault.boston.devel.redhat.com (segfault.boston.devel.redhat.com [10.19.60.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 157F05C62B; Mon, 17 Aug 2020 20:55:21 +0000 (UTC) From: Jeff Moyer To: Jens Axboe Cc: io-uring@vger.kernel.org, david@fromorbit.com Subject: Re: [PATCHSET 0/2] io_uring: handle short reads internally References: <20200813175605.993571-1-axboe@kernel.dk> <99c39782-6523-ae04-3d48-230f40bc5d05@kernel.dk> <9f050b83-a64a-c112-fc26-309342076c71@kernel.dk> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 Date: Mon, 17 Aug 2020 16:55:19 -0400 In-Reply-To: (Jens Axboe's message of "Thu, 13 Aug 2020 16:31:48 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Sender: io-uring-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org Jens Axboe writes: > On 8/13/20 4:21 PM, Jeff Moyer wrote: >> Jens Axboe writes: >> >>>>>> BTW, what git sha did you run? >>>>> >>>>> I do see a failure with dm on that, I'll take a look. >>>> >>>> I ran it on a file system atop nvme with 8 poll queues. >>>> >>>> liburing head: 9e1d69e078ee51f253a829ff421b17cfc996d158 >>>> linux-block head: ff1353802d86a9d8e40ef1377efb12a1d3000a20 >>> >>> Fixed it, and actually enabled a further cleanup. >> >> Great, thanks! Did you push that out somewhere? > > It's pushed to io_uring-5.9, current sha is: > > ee6ac2d3d5cc50d58ca55a5967671c9c1f38b085 > > FWIW, the issue was just for fixed buffers. It's running through the > usual testing now. OK. Since it was an unrelated problem, I was expecting a separate commit for it. What was the exact issue? Is it something that needs backporting to -stable? -Jeff