iwd.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: iwd@lists.01.org
Subject: Re: [PATCH v4 1/5] sae: don't send commit/confirm in confirmed state
Date: Wed, 08 Sep 2021 16:48:32 -0500	[thread overview]
Message-ID: <1fdeae1b-4015-5476-07c4-84366061ff9f@gmail.com> (raw)
In-Reply-To: <20210908213201.97115-1-prestwoj@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 973 bytes --]

Hi James,

On 9/8/21 4:31 PM, James Prestwood wrote:
> This works around a hostapd bug (described more in the TODO comment)
> which is exposed because of the kernels overly agressive re-transmit
> behavior on missed ACKs. Combined this results in a death if the
> initial commit is not acked. This behavior has been identified in
> consumer access points and likely won't ever be patched for older
> devices. Because of this IWD must work around the problem which can
> be eliminated by not sending out this commit message.
> 
> This bug was reported to the hostapd ML:
> 
> https://lists.infradead.org/pipermail/hostap/2021-September/039842.html
> 
> This change should not cause any compatibility problems to non-hostapd
> access points and is identical to how wpa_supplicant treats this
> scenario.
> ---
>   src/sae.c | 25 +++++++++++++++++++++++++
>   1 file changed, 25 insertions(+)
> 

Patches 1-3 and 5 applied, thanks.

Regards,
-Denis

      parent reply	other threads:[~2021-09-08 21:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-08 21:31 [PATCH v4 1/5] sae: don't send commit/confirm in confirmed state James Prestwood
2021-09-08 21:31 ` [PATCH v4 2/5] auth-proto: document acceptable return values for auth-protos James Prestwood
2021-09-08 21:31 ` [PATCH v4 3/5] mpdu: add MMPDU_STATUS_CODE_SAE_PK James Prestwood
2021-09-08 21:32 ` [PATCH v4 4/5] netdev: handle non-fatal auth-proto returns James Prestwood
2021-09-08 21:32 ` [PATCH v4 5/5] auto-t: add sae test for non-acked commit James Prestwood
2021-09-08 21:48 ` Denis Kenzior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1fdeae1b-4015-5476-07c4-84366061ff9f@gmail.com \
    --to=denkenz@gmail.com \
    --cc=iwd@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).