From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.01.org
Subject: [PATCH v3 4/4] auto-t: add sae test for non-acked commit
Date: Wed, 08 Sep 2021 13:48:05 -0700 [thread overview]
Message-ID: <20210908204805.92005-4-prestwoj@gmail.com> (raw)
In-Reply-To: <20210908204805.92005-1-prestwoj@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2951 bytes --]
This test simulates the scenario where IWDs commit is not acked which
exposes a hostapd bug that ultimately fails the connection. This behavior
can be seen by reverting the commit which works around this issue:
"sae: don't send commit in confirmed state"
With the above patch applied this test should pass.
Note: The existing timeout test was reused as it was not of much use
anyways. All it did was block auth/assoc frames and expect a failure
which didn't exercise any SAE logic anyways.
---
autotests/testSAE/timeout_test.py | 41 ++++++++++++++++---------------
1 file changed, 21 insertions(+), 20 deletions(-)
diff --git a/autotests/testSAE/timeout_test.py b/autotests/testSAE/timeout_test.py
index abef109b..1792f1c0 100644
--- a/autotests/testSAE/timeout_test.py
+++ b/autotests/testSAE/timeout_test.py
@@ -9,13 +9,12 @@ from iwd import IWD
from iwd import PSKAgent
from iwd import NetworkType
from hwsim import Hwsim
+from hostapd import HostapdCLI
+from config import ctx
class Test(unittest.TestCase):
def validate_connection(self, wd):
- hwsim = Hwsim()
- bss_radio = hwsim.get_radio('rad0')
-
psk_agent = PSKAgent(["secret123", "secret123"])
wd.register_psk_agent(psk_agent)
@@ -30,29 +29,31 @@ class Test(unittest.TestCase):
condition = 'not obj.connected'
wd.wait_for_object_condition(network.network_object, condition)
+ network.network_object.connect()
+
+ condition = 'obj.state == DeviceState.connected'
+ wd.wait_for_object_condition(device, condition)
+
+ def test_not_acked_commit(self):
+ #
+ # TODO: This merely forces group 19 by acting as a 'buggy' AP. This is
+ # needed because the hwsim rule only matches once and must be matched
+ # on the first commit, not during group negotiation.
+ #
+ hostapd = HostapdCLI(config='ssidSAE.conf')
+ hostapd.set_value('vendor_elements', 'dd0cf4f5e8050500000000000000')
+
+ hwsim = Hwsim()
+ bss_radio = hwsim.get_radio('rad0')
+
rule0 = hwsim.rules.create()
rule0.source = bss_radio.addresses[0]
- rule0.bidirectional = True
rule0.drop = True
rule0.prefix = 'b0'
+ rule0.match_times = 1
+ rule0.drop_ack = True
rule0.enabled = True
- wd.wait(1)
- print(rule0)
-
- with self.assertRaises(iwd.FailedEx):
- network.network_object.connect()
-
- condition = 'not obj.connected'
- wd.wait_for_object_condition(network.network_object, condition)
-
- rule0.prefix = '00'
- with self.assertRaises(iwd.FailedEx):
- network.network_object.connect()
-
- wd.unregister_psk_agent(psk_agent)
-
- def test_connection_success(self):
wd = IWD(True)
self.validate_connection(wd)
--
2.31.1
prev parent reply other threads:[~2021-09-08 20:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 20:48 [PATCH v3 1/4] sae: don't send commit/confirm in confirmed state James Prestwood
2021-09-08 20:48 ` [PATCH v3 2/4] auth-proto: document acceptable return values for auth-protos James Prestwood
2021-09-08 20:48 ` [PATCH v3 3/4] netdev: handle non-fatal auth-proto returns James Prestwood
2021-09-08 20:48 ` James Prestwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210908204805.92005-4-prestwoj@gmail.com \
--to=prestwoj@gmail.com \
--cc=iwd@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).