From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>
Subject: [PATCH] ap: disallow TKIP and 'use group cipher'
Date: Mon, 24 Oct 2022 13:47:10 -0700 [thread overview]
Message-ID: <20221024204710.163107-1-prestwoj@gmail.com> (raw)
The EAPoL SM does not support either of these ciphers when acting
as an authenticator since ARC4 encryption is not implemented.
(see eapol_encrypt_key_data() for key descriptor version 1)
This can cause 4-way failures if e.g. the hardware only supports
TKIP. Rather than fail the 4-way its better to not even start the
AP and return NotSupported.
---
src/ap.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/src/ap.c b/src/ap.c
index 429de560..94eff2a2 100644
--- a/src/ap.c
+++ b/src/ap.c
@@ -3303,7 +3303,15 @@ struct ap_state *ap_start(struct netdev *netdev, struct l_settings *config,
err = -EINVAL;
/* TODO: Add all ciphers supported by wiphy */
- ap->ciphers = wiphy_select_cipher(wiphy, 0xffff);
+ ap->ciphers = wiphy_select_cipher(wiphy,
+ ~(IE_RSN_CIPHER_SUITE_USE_GROUP_CIPHER |
+ IE_RSN_CIPHER_SUITE_TKIP));
+ if (!ap->ciphers) {
+ l_error("Hardware does not support required pairwise ciphers!");
+ err = -ENOTSUP;
+ goto error;
+ }
+
ap->group_cipher = wiphy_select_cipher(wiphy, 0xffff);
ap->beacon_interval = 100;
ap->networks = l_queue_new();
--
2.34.3
next reply other threads:[~2022-10-24 20:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 20:47 James Prestwood [this message]
2022-10-24 22:26 ` [PATCH] ap: disallow TKIP and 'use group cipher' Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221024204710.163107-1-prestwoj@gmail.com \
--to=prestwoj@gmail.com \
--cc=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).