* [PATCH 1/3] gitignore: add compile_commands.json
@ 2022-11-20 16:09 Neehar Vijay
2022-11-20 16:09 ` [PATCH 2/3] gitignore: add .ccls-cache Neehar Vijay
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Neehar Vijay @ 2022-11-20 16:09 UTC (permalink / raw)
To: iwd; +Cc: Neehar Vijay
This file is a compilation command database used by clangd and ccls,
and can be generated by tools like https://github.com/rizsotto/Bear.
$ bear -- make clean all
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index 61b3638d..f215701d 100644
--- a/.gitignore
+++ b/.gitignore
@@ -5,6 +5,7 @@
.deps
.dirstamp
.cache
+compile_commands.json
tags
cscope.*
Makefile
--
2.38.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/3] gitignore: add .ccls-cache
2022-11-20 16:09 [PATCH 1/3] gitignore: add compile_commands.json Neehar Vijay
@ 2022-11-20 16:09 ` Neehar Vijay
2022-11-20 16:09 ` [PATCH 3/3] client: fix non-interactive mode in some cases Neehar Vijay
2022-11-22 17:20 ` [PATCH 1/3] gitignore: add compile_commands.json Denis Kenzior
2 siblings, 0 replies; 4+ messages in thread
From: Neehar Vijay @ 2022-11-20 16:09 UTC (permalink / raw)
To: iwd; +Cc: Neehar Vijay
This directory is used by ccls.
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index f215701d..bc429883 100644
--- a/.gitignore
+++ b/.gitignore
@@ -5,6 +5,7 @@
.deps
.dirstamp
.cache
+.ccls-cache
compile_commands.json
tags
cscope.*
--
2.38.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 3/3] client: fix non-interactive mode in some cases
2022-11-20 16:09 [PATCH 1/3] gitignore: add compile_commands.json Neehar Vijay
2022-11-20 16:09 ` [PATCH 2/3] gitignore: add .ccls-cache Neehar Vijay
@ 2022-11-20 16:09 ` Neehar Vijay
2022-11-22 17:20 ` [PATCH 1/3] gitignore: add compile_commands.json Denis Kenzior
2 siblings, 0 replies; 4+ messages in thread
From: Neehar Vijay @ 2022-11-20 16:09 UTC (permalink / raw)
To: iwd; +Cc: Neehar Vijay
Before this change, I noticed that some non-interactive commands
don't work,
$ iwctl version
$ iwctl help
while other ones do.
$ iwctl station wlan0 show
This seems to be a typo bug in the if clause checking for additional
arguments.
---
client/command.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/client/command.c b/client/command.c
index dbd97703..84be680c 100644
--- a/client/command.c
+++ b/client/command.c
@@ -753,7 +753,7 @@ options_parsed:
argv += optind;
argc -= optind;
- if (argc < 2) {
+ if (argc < 1) {
interactive_mode = true;
return false;
}
--
2.38.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] gitignore: add compile_commands.json
2022-11-20 16:09 [PATCH 1/3] gitignore: add compile_commands.json Neehar Vijay
2022-11-20 16:09 ` [PATCH 2/3] gitignore: add .ccls-cache Neehar Vijay
2022-11-20 16:09 ` [PATCH 3/3] client: fix non-interactive mode in some cases Neehar Vijay
@ 2022-11-22 17:20 ` Denis Kenzior
2 siblings, 0 replies; 4+ messages in thread
From: Denis Kenzior @ 2022-11-22 17:20 UTC (permalink / raw)
To: Neehar Vijay, iwd
Hi Neehar,
On 11/20/22 10:09, Neehar Vijay wrote:
> This file is a compilation command database used by clangd and ccls,
> and can be generated by tools like https://github.com/rizsotto/Bear.
>
> $ bear -- make clean all
> ---
> .gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
All applied, thanks.
Regards,
-Denis
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-22 17:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-20 16:09 [PATCH 1/3] gitignore: add compile_commands.json Neehar Vijay
2022-11-20 16:09 ` [PATCH 2/3] gitignore: add .ccls-cache Neehar Vijay
2022-11-20 16:09 ` [PATCH 3/3] client: fix non-interactive mode in some cases Neehar Vijay
2022-11-22 17:20 ` [PATCH 1/3] gitignore: add compile_commands.json Denis Kenzior
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).