From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>
Subject: [PATCH 2/2] ap: handle -ENOTSUP when getting the GTK
Date: Fri, 24 Feb 2023 09:59:28 -0800 [thread overview]
Message-ID: <20230224175928.1460558-2-prestwoj@gmail.com> (raw)
In-Reply-To: <20230224175928.1460558-1-prestwoj@gmail.com>
Some hardware does not support this, so use a zero RSC in this
case rather than failing the association.
---
src/ap.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/ap.c b/src/ap.c
index fee5a6c8..aa1ae543 100644
--- a/src/ap.c
+++ b/src/ap.c
@@ -1499,10 +1499,15 @@ static void ap_gtk_query_cb(struct l_genl_msg *msg, void *user_data)
struct sta_state *sta = user_data;
const void *gtk_rsc;
uint8_t zero_gtk_rsc[6];
+ int err;
sta->gtk_query_cmd_id = 0;
- if (l_genl_msg_get_error(msg) < 0)
+ err = l_genl_msg_get_error(msg);
+ if (err == -ENOTSUP) {
+ gtk_rsc = zero_gtk_rsc;
+ goto start_rsna;
+ } else if (err < 0)
goto error;
gtk_rsc = nl80211_parse_get_key_seq(msg);
@@ -1511,6 +1516,7 @@ static void ap_gtk_query_cb(struct l_genl_msg *msg, void *user_data)
gtk_rsc = zero_gtk_rsc;
}
+start_rsna:
ap_start_rsna(sta, gtk_rsc);
return;
--
2.34.3
prev parent reply other threads:[~2023-02-24 17:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 17:59 [PATCH 1/2] ap: check FULL_AP_CLIENT_STATE for NEW_STATION James Prestwood
2023-02-24 17:59 ` James Prestwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230224175928.1460558-2-prestwoj@gmail.com \
--to=prestwoj@gmail.com \
--cc=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).