From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>
Subject: [PATCH v3 3/4] wiphy: make wiphy work queue reentrant
Date: Thu, 18 May 2023 09:49:59 -0700 [thread overview]
Message-ID: <20230518165000.275611-3-prestwoj@gmail.com> (raw)
In-Reply-To: <20230518165000.275611-1-prestwoj@gmail.com>
In some situations its convenient for the same work item to be
inserted (rescheduled) while its in progress. FT for example does
this now if a roam fails. The same ft_work item gets re-inserted
which, currently, is not safe to do since the item is modified
and removed once completed.
Fix this by introducing wiphy_radio_work_reschedule which is an
explicit API for re-inserting work items from within the do_work
callback.
The wiphy work logic was changed around slightly to remove the item
at the head of the queue prior to starting and note the ID going
into do_work. If do_work signaled done and ID changed we know it
was re-inserted and can skip the destroy logic and move onto the
next item. If the item is not done continue as normal but set the
priority to INT_MIN, as usual, to prevent other items from getting
to the head of the queue.
---
src/wiphy.c | 45 +++++++++++++++++++++++++++++++++++++--------
src/wiphy.h | 2 ++
2 files changed, 39 insertions(+), 8 deletions(-)
v3:
* Reworked the logic to simplify as well as added an explicit
API for work rescheduling to make it clear to the caller.
diff --git a/src/wiphy.c b/src/wiphy.c
index 2db2d2cd..d06b2447 100644
--- a/src/wiphy.c
+++ b/src/wiphy.c
@@ -2574,16 +2574,13 @@ static void wiphy_radio_work_next(struct wiphy *wiphy)
{
struct wiphy_radio_work_item *work;
bool done;
+ uint32_t id;
- work = l_queue_peek_head(wiphy->work);
+ work = l_queue_pop_head(wiphy->work);
if (!work)
return;
- /*
- * Ensures no other work item will get inserted before this one while
- * the work is being done.
- */
- work->priority = INT_MIN;
+ id = work->id;
l_debug("Starting work item %u", work->id);
@@ -2592,15 +2589,25 @@ static void wiphy_radio_work_next(struct wiphy *wiphy)
wiphy->work_in_callback = false;
if (done) {
- work->id = 0;
+ /* Item was rescheduled, don't destroy */
+ if (work->id != id)
+ goto next;
- l_queue_remove(wiphy->work, work);
+ work->id = 0;
wiphy->work_in_callback = true;
destroy_work(work);
wiphy->work_in_callback = false;
+next:
wiphy_radio_work_next(wiphy);
+ } else {
+ /*
+ * Ensures no other work item will get inserted before this one
+ * while the work is being done.
+ */
+ work->priority = INT_MIN;
+ l_queue_push_head(wiphy->work, work);
}
}
@@ -2684,6 +2691,28 @@ int wiphy_radio_work_is_running(struct wiphy *wiphy, uint32_t id)
return item == l_queue_peek_head(wiphy->work) ? 1 : 0;
}
+uint32_t wiphy_radio_work_reschedule(struct wiphy *wiphy,
+ struct wiphy_radio_work_item *item)
+{
+ /*
+ * This should only be called from within the do_work callback, meaning
+ * the item should not be in the queue. Any re-insertion on a running
+ * item after do_work is not allowed.
+ */
+ if (L_WARN_ON(wiphy_radio_work_is_running(wiphy, item->id) != -ENOENT))
+ return 0;
+
+ work_ids++;
+
+ l_debug("Rescheduling work item %u, new id %u", item->id, work_ids);
+
+ item->id = work_ids;
+
+ l_queue_insert(wiphy->work, item, insert_by_priority, NULL);
+
+ return item->id;
+}
+
static int wiphy_init(void)
{
struct l_genl *genl = iwd_get_genl();
diff --git a/src/wiphy.h b/src/wiphy.h
index d5d1cc8f..f4f205ad 100644
--- a/src/wiphy.h
+++ b/src/wiphy.h
@@ -168,3 +168,5 @@ uint32_t wiphy_radio_work_insert(struct wiphy *wiphy,
const struct wiphy_radio_work_item_ops *ops);
void wiphy_radio_work_done(struct wiphy *wiphy, uint32_t id);
int wiphy_radio_work_is_running(struct wiphy *wiphy, uint32_t id);
+uint32_t wiphy_radio_work_reschedule(struct wiphy *wiphy,
+ struct wiphy_radio_work_item *item);
--
2.25.1
next prev parent reply other threads:[~2023-05-18 16:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 16:49 [PATCH v3 1/4] auto-t: modify PSK-roam test to use FT failure path James Prestwood
2023-05-18 16:49 ` [PATCH v3 2/4] auto-t: increase timeout in testPSK-roam James Prestwood
2023-05-18 16:49 ` James Prestwood [this message]
2023-05-18 16:50 ` [PATCH v3 4/4] station: use wiphy_radio_work_reschedule in FT path James Prestwood
2023-05-22 14:37 ` [PATCH v3 1/4] auto-t: modify PSK-roam test to use FT failure path Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230518165000.275611-3-prestwoj@gmail.com \
--to=prestwoj@gmail.com \
--cc=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).