Hi Denis.

On Wed, 25 Aug 2021 at 15:49, Denis Kenzior <denkenz@gmail.com> wrote:
> On 8/23/21 9:14 AM, Andrew Zaborowski wrote:
> > ---
> >   src/ie.c | 347 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >   src/ie.h |  38 ++++++
> >   2 files changed, 385 insertions(+)
> >
>
> <snip>
>
> > +     if (*resp_ctrl & IE_FILS_IP_ADDR_RESP_CTRL_IPV4_GW_INCLUDED) {
> > +             ptr = NEXT_FIELD(data, len, 10);
> > +             info.ipv4_gateway = l_get_u32(ptr);
> > +             memcpy(info.ipv4_gateway_mac, ptr + 4, 6);
> > +
> > +             /* Check gateway is on the same subnet */
> > +             if (info.ipv4_addr && (ntohl(info.ipv4_addr ^ info.ipv4_gateway) &
> > +                             util_netmask_from_prefix(info.ipv4_prefix_len)))
>
> This line is over 80 chars.  Also, it seems you're repeating this pattern in
> many places by now.  Please add a utility function so one doesn't wonder what
> this is doing on every reading ;)

Ok, makes sense.

Best regards