Re: [PATCH 1/2] client: fix spurious newlines in station show

[James Prestwood <prestwoj@gmail.com>]

On Wed, 2022-11-02 at 14:51 +0530, eNV25 wrote:
> This change removes duplicated calls to display_table_footer(), in
> station show.
> 
> Before this change, the bug caused an extra newline to be output
> every
> time the table updated. This only occurred when the network was
> disconnected.
> 
>     $ iwctl
>     [iwd]# station wlan0 show
> 
> ---
>  client/station.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/client/station.c b/client/station.c
> index b070807b..1d958ef2 100644
> --- a/client/station.c
> +++ b/client/station.c
> @@ -217,15 +217,9 @@ static void display_station(const char
> *device_name,
>                         47, network_get_name(station-
> >connected_network));
>  
>                 display_addresses(device_name);
> -
> -               /*
> -                * If connected the diagnostic interface is
> presumably up so
> -                * don't add the table footer just yet.
> -                */
> -               return;
>         }
>  
> -       display_table_footer();
> +       /* The table footer is handled by cmd_show. */
>  }
>  
>  static void display_station_inline(const char *margin, const void
> *data)

LGTM, I noticed this happening but never spent the time to diagnose it.
Thanks!