From: Luca Coelho <luca@coelho.fi>
To: kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH 4/8] iwlwifi: pcie: define FW_RESET_TIMEOUT for clarity
Date: Wed, 10 Feb 2021 17:23:51 +0200 [thread overview]
Message-ID: <iwlwifi.20210210172142.f71c99f461ff.If32fe0afed277ec99ba0d7e2615c27a8a80a0d29@changeid> (raw)
In-Reply-To: <20210210152355.419776-1-luca@coelho.fi>
From: Matti Gottlieb <matti.gottlieb@intel.com>
Move fw reset timeout to a FW_RESET_TIMEOUT macro
for better readability.
Signed-off-by: Matti Gottlieb <matti.gottlieb@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
drivers/net/wireless/intel/iwlwifi/pcie/trans-gen2.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/trans-gen2.c b/drivers/net/wireless/intel/iwlwifi/pcie/trans-gen2.c
index 0e55aacd6175..497ef3405da3 100644
--- a/drivers/net/wireless/intel/iwlwifi/pcie/trans-gen2.c
+++ b/drivers/net/wireless/intel/iwlwifi/pcie/trans-gen2.c
@@ -10,6 +10,8 @@
#include "internal.h"
#include "fw/dbg.h"
+#define FW_RESET_TIMEOUT (HZ / 5)
+
/*
* Start up NIC's basic functionality after it has been reset
* (e.g. after platform boot, or shutdown via iwl_pcie_apm_stop())
@@ -104,7 +106,7 @@ static void iwl_trans_pcie_fw_reset_handshake(struct iwl_trans *trans)
/* wait 200ms */
ret = wait_event_timeout(trans_pcie->fw_reset_waitq,
- trans_pcie->fw_reset_done, HZ / 5);
+ trans_pcie->fw_reset_done, FW_RESET_TIMEOUT);
if (!ret)
IWL_ERR(trans,
"firmware didn't ACK the reset - continue anyway\n");
--
2.30.0
next prev parent reply other threads:[~2021-02-10 15:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 15:23 [PATCH 0/8] iwlwifi: updates intended for v5.12 2021-02-10 part 2 Luca Coelho
2021-02-10 15:23 ` [PATCH 1/8] iwlwifi: mvm: reduce the print severity of failing getting NIC temp Luca Coelho
2021-02-10 23:57 ` Luca Coelho
2021-02-10 15:23 ` [PATCH 2/8] iwlwifi: mvm: global PM mode does not reset after FW crash Luca Coelho
2021-02-10 15:23 ` [PATCH 3/8] iwlwifi: pnvm: set the PNVM again if it was already loaded Luca Coelho
2021-02-10 15:23 ` Luca Coelho [this message]
2021-02-10 15:23 ` [PATCH 5/8] iwlwifi: pnvm: increment the pointer before checking the TLV Luca Coelho
2021-02-10 15:23 ` [PATCH 6/8] iwlwifi: pnvm: move file loading code to a separate function Luca Coelho
2021-02-10 15:23 ` [PATCH 7/8] iwlwifi: pnvm: implement reading PNVM from UEFI Luca Coelho
2021-02-10 18:01 ` kernel test robot
2021-02-10 18:01 ` kernel test robot
2021-02-10 15:23 ` [PATCH 8/8] iwlwifi: bump FW API to 62 for AX devices Luca Coelho
2021-02-10 23:58 ` Luca Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=iwlwifi.20210210172142.f71c99f461ff.If32fe0afed277ec99ba0d7e2615c27a8a80a0d29@changeid \
--to=luca@coelho.fi \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.