kdevops.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: Daniel Gomez <da.gomez@samsung.com>
Cc: "kdevops@lists.linux.dev" <kdevops@lists.linux.dev>,
	"jlayton@kernel.org" <jlayton@kernel.org>
Subject: Re: [PATCH 0/5] Fix choice/endchoice kconfig options
Date: Tue, 12 Sep 2023 14:49:43 -0700	[thread overview]
Message-ID: <ZQDc94LINMdPY3YE@bombadil.infradead.org> (raw)
In-Reply-To: <20230912194908.939107-1-da.gomez@samsung.com>

On Tue, Sep 12, 2023 at 07:49:11PM +0000, Daniel Gomez wrote:
> Hi,
> 
> As you may know, Jeff Layton found the way to fix the choice/enchoice issue
> by removing the redundant string the config selected is assigned to [1].
> 
> [1] 95f5695f fstests: remove redundant string prompts for fstype
> 
> These patches are meant to fix that in the terraform section. While most of the
> patches are trivial, I'd like to know what you guys think about dropping a
> choice/endchoice config ("AWS name search") that depends on an previous
> choice/endchoice option ("AWS AMI owner") but we keep the config that the first
> multichoice was assigned to (TERRAFORM_AWS_NS).
> 
> Hope I explained this correctly. Otherwise, please check patch [2] and ask any
> question.
> 
> [2] terraform: aws: hide TERRAFORM_AWS_AMI_OWNER and drop AWS name search
> 
> Patch [3] it's the same but with less choice/endchoice configs and perhaps
> simpler to see the intention.
> 
> [3] terraform: aws: hide AWS availability region option
> 
> Note: I did add/merge some spelling corrections. If you think it's too noisy
> and not appropriate, I can make a separate commit for that.
> 
> The other patches remove choice/endchoice if only one option is available as Jeff
> suggested and/or hide the config by removing the redundant string.

Looks all good, and goes tested by me, so:

Acked-by: Luis Chamberlain <mcgrof@kernel.org>
Tested-by: Luis Chamberlain <mcgrof@kernel.org>

Please push!

  Luis

  parent reply	other threads:[~2023-09-12 21:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20230912194912eucas1p20d99edc0e417cda49b132eb8b7777198@eucas1p2.samsung.com>
2023-09-12 19:49 ` [PATCH 0/5] Fix choice/endchoice kconfig options Daniel Gomez
     [not found]   ` <CGME20230912194914eucas1p2e6fc3cdcb7745a011c0760849f08eca8@eucas1p2.samsung.com>
2023-09-12 19:49     ` [PATCH 1/5] terraform: gce: remove redundant string for cpu and mem choice Daniel Gomez
     [not found]   ` <CGME20230912194916eucas1p18db4cbc48e72969e5ab4bdb7a0bb1ae9@eucas1p1.samsung.com>
2023-09-12 19:49     ` [PATCH 2/5] terraform: aws: hide AWS availability region option Daniel Gomez
     [not found]   ` <CGME20230912194917eucas1p255a2d6e940671576c95355d4ab9e99d4@eucas1p2.samsung.com>
2023-09-12 19:49     ` [PATCH 3/5] terraform: aws: hide TERRAFORM_AWS_AMI_OWNER and drop AWS name search Daniel Gomez
     [not found]   ` <CGME20230912194919eucas1p1acf335160e5a2750745c5fba9084b080@eucas1p1.samsung.com>
2023-09-12 19:49     ` [PATCH 4/5] terraform: aws: drop multichoice option for TERRAFORM_AWS_VIRT_TYPE Daniel Gomez
     [not found]   ` <CGME20230912194920eucas1p188665453a470e3ef71f957c1b063ba4a@eucas1p1.samsung.com>
2023-09-12 19:49     ` [PATCH 5/5] terraform: aws: hide TERRAFORM_AWS_INSTANCE_TYPE Daniel Gomez
2023-09-12 21:49   ` Luis Chamberlain [this message]
2023-09-13  4:56     ` [PATCH 0/5] Fix choice/endchoice kconfig options Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZQDc94LINMdPY3YE@bombadil.infradead.org \
    --to=mcgrof@kernel.org \
    --cc=da.gomez@samsung.com \
    --cc=jlayton@kernel.org \
    --cc=kdevops@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).