kdevops.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: Ross Vandegrift <ross@kallisti.us>
Cc: kdevops@lists.linux.dev
Subject: Re: [PATCH v2 2/3] vagrant arm64: kconfig/ansible to enable arm64
Date: Tue, 12 Sep 2023 23:36:27 -0700	[thread overview]
Message-ID: <ZQFYa/v+ZtaWz78f@bombadil.infradead.org> (raw)
In-Reply-To: <20230913043512.6083-2-ross@kallisti.us>

On Tue, Sep 12, 2023 at 09:35:12PM -0700, Ross Vandegrift wrote:
> diff --git a/vagrant/Kconfig b/vagrant/Kconfig
> index e9e8b3d9..5d7d9657 100644
> --- a/vagrant/Kconfig
> +++ b/vagrant/Kconfig
> @@ -198,7 +200,9 @@ endif # HAVE_LIBVIRT_PCIE_PASSTHROUGH
>  
>  choice
>  	prompt "Machine type to use"
> -	default LIBVIRT_MACHINE_TYPE_Q35
> +	default LIBVIRT_MACHINE_TYPE_Q35 if TARGET_ARCH_X86_64
> +	default LIBVIRT_MACHINE_TYPE_VIRT if TARGET_ARCH_ARM64
> +	default LIBVIRT_MACHINE_TYPE_DEFAULT if (!TARGET_ARCH_X86_64 && !TARGET_ARCH_ARM64)

We might as well delete LIBVIRT_MACHINE_TYPE_DEFAULT :)

> +config LIBVIRT_ARM64_ENABLE
> +	bool
> +	depends on TARGET_ARCH_ARM64
> +	help
> +	  True if arch is arm64 and libvirt is enabled.
> +

config LIBVIRT_ARM64_ENABLE
	bool
	default TARGET_ARCH_ARM64

So long as that is put under libvirt, ie, when libvirt is enabled.

Otherwise looks good!

  Luis

  reply	other threads:[~2023-09-13  6:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-13  4:35 [PATCH v2 1/3] vagrant arm64: arch indep kconfig/ansible options Ross Vandegrift
2023-09-13  4:35 ` [PATCH v2 2/3] vagrant arm64: kconfig/ansible to enable arm64 Ross Vandegrift
2023-09-13  6:36   ` Luis Chamberlain [this message]
2023-09-13  4:35 ` [PATCH v2 3/3] vagrant arm64: add opensuse arm64 images Ross Vandegrift
2023-09-13  6:45   ` Luis Chamberlain
2023-09-13  6:07 ` [PATCH v2 1/3] vagrant arm64: arch indep kconfig/ansible options Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZQFYa/v+ZtaWz78f@bombadil.infradead.org \
    --to=mcgrof@kernel.org \
    --cc=kdevops@lists.linux.dev \
    --cc=ross@kallisti.us \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).