kdevops.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: Ross Vandegrift <ross@kallisti.us>
Cc: kdevops@lists.linux.dev
Subject: Re: [PATCH v2 3/3] vagrant arm64: add opensuse arm64 images
Date: Tue, 12 Sep 2023 23:45:24 -0700	[thread overview]
Message-ID: <ZQFahCw8HZcluidW@bombadil.infradead.org> (raw)
In-Reply-To: <20230913043512.6083-3-ross@kallisti.us>

On Tue, Sep 12, 2023 at 09:35:13PM -0700, Ross Vandegrift wrote:
> Tumbleweed has arm64 vagrant images already and the one I tested booted up as
> expected.
> 
> Signed-off-by: Ross Vandegrift <ross@kallisti.us>
> ---
>  vagrant/Kconfig.opensuse | 31 ++++++++++++++++++++++++++++++-
>  1 file changed, 30 insertions(+), 1 deletion(-)
> 
> diff --git a/vagrant/Kconfig.opensuse b/vagrant/Kconfig.opensuse
> index 2ffb1f31..685018b7 100644
> --- a/vagrant/Kconfig.opensuse
> +++ b/vagrant/Kconfig.opensuse
> @@ -3,7 +3,8 @@ if VAGRANT_OPENSUSE
>  
>  choice
>  	prompt "OpenSUSE release to use"
> -	default VAGRANT_OPENSUSE_X86_64_LEAP_15_3
> +	default VAGRANT_OPENSUSE_X86_64_LEAP_15_3 if TARGET_ARCH_X86_64
> +	default VAGRANT_OPENSUSE_ARM64_TW_20230828 if TARGET_ARCH_ARM64

Did you mean VAGRANT_OPENSUSE_ARM64_TW here instead of VAGRANT_OPENSUSE_ARM64_TW_20230828?
>  
>  config VAGRANT_OPENSUSE_X86_64_TW
>  	bool "opensuse/Tumbleweed.x86_64"
> @@ -78,6 +79,13 @@ config VAGRANT_OPENSUSE_X86_64_LEAP_15_4
>  	help
>  	  This enables the OpenSUSE Leap 15.4 release.
>  
> +config VAGRANT_OPENSUSE_ARM64_TW
> +	bool "opensuse/Tumbleweed.aarch64"
> +	depends on TARGET_ARCH_ARM64
> +	help
> +	  Enable this to be able to select between the supported OpenSUSE
> +	  Tumbleweed releases.
> +
>  endchoice
>  
>  if VAGRANT_OPENSUSE_X86_64_TW
> @@ -157,6 +165,27 @@ endchoice
>  
>  endif # VAGRANT_OPENSUSE_X86_64_TW
>  
> +if VAGRANT_OPENSUSE_ARM64_TW
> +
> +choice
> +	prompt "opensuse/Tumbleweed.aarch64 version to use"
> +	default VAGRANT_OPENSUSE_X86_64_TW_1020230828
> +
> +config VAGRANT_OPENSUSE_X86_64_TW_1020230828

These twho are x86 above.. while this is for arm64.

> +	bool "opensuse/Tumbleweed.aarch64 1.0.20230828"
> +	select HAVE_VAGRANT_BOX_VERSION
> +	select HAVE_DISTRO_XFS_SUPPORTS_CRC if FSTESTS_XFS
> +	select HAVE_DISTRO_XFS_SUPPORTS_EXTERNAL_LOG if FSTESTS_XFS
> +	select HAVE_DISTRO_XFS_SUPPORTS_REFLINKS if FSTESTS_XFS
> +	select HAVE_DISTRO_XFS_SUPPORTS_BIGBLOCKS if FSTESTS_XFS
> +	help
> +	  This option will set the target guest to opensuse/Tumbleweed.aarch64
> +	  release 1.0.20230828.
> +
> +endchoice
> +
> +endif # VAGRANT_OPENSUSE_ARM64_TW
> +
>  config VAGRANT_OPENSUSE_BOX_SHORT
>  	string
>  	default "tw" if VAGRANT_OPENSUSE_X86_64_TW
> -- 
> 2.39.2

Seems like you are missing the corresponding VAGRANT_BOX and VAGRANT_BOX_VERSION
updates needed on vagrant/Kconfig.

  Luis

  reply	other threads:[~2023-09-13  6:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-13  4:35 [PATCH v2 1/3] vagrant arm64: arch indep kconfig/ansible options Ross Vandegrift
2023-09-13  4:35 ` [PATCH v2 2/3] vagrant arm64: kconfig/ansible to enable arm64 Ross Vandegrift
2023-09-13  6:36   ` Luis Chamberlain
2023-09-13  4:35 ` [PATCH v2 3/3] vagrant arm64: add opensuse arm64 images Ross Vandegrift
2023-09-13  6:45   ` Luis Chamberlain [this message]
2023-09-13  6:07 ` [PATCH v2 1/3] vagrant arm64: arch indep kconfig/ansible options Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZQFahCw8HZcluidW@bombadil.infradead.org \
    --to=mcgrof@kernel.org \
    --cc=kdevops@lists.linux.dev \
    --cc=ross@kallisti.us \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).