kdevops.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Frederick Lawler <fred@cloudflare.com>,
	kdevops@lists.linux.dev, kernel-team@cloudflare.com,
	linux-fsdevel@vger.kernel.org,
	Chandan Babu R <chandan.babu@oracle.com>,
	Leah Rumancik <leah.rumancik@gmail.com>,
	"Darrick J. Wong" <djwong@kernel.org>
Subject: Re: [RFC PATCH kdevops 0/2] augment expunge list for v6.1.53
Date: Mon, 18 Sep 2023 11:52:31 -0700	[thread overview]
Message-ID: <ZQicb1SyQGxlxJeL@bombadil.infradead.org> (raw)
In-Reply-To: <CAOQ4uxiGYF8EhqxM91_vrGSVYoX7dAf154btVobbsj=RUQNWAQ@mail.gmail.com>

On Sat, Sep 16, 2023 at 12:23:54PM +0300, Amir Goldstein wrote:
> AFAIK, we never bothered to create two different baselines from scratch in
> two different envs (e.g. libvirt and GCE/OCI) and compare them.

The experience so far has been that sparse files help find more issues
than using real drives and it is why its a default. And even if you use
a cloud solution you can use sparse files too. Only recently did I add
support to use real NVMe drive support and so to create partitions. That
should find less issues, however I did the work so to be able to test
LBS devices.

> But as it is, you already have my baseline from libvirt/kvm -
> I don't think that it makes sense to add to 6.1.y expunge lists
> failures due to test env change, unless you were able to prove that either:
> 1. Those tests did not run in my env
> 2. You env manages to expose a bug that my env did not expose
> 
> I can help with #1 by committing results from a run in my env.
> #2 is harder - you will need to analyse the failures in your env
> and understand them.

My guess so far is that the older expunges used an older version of
fstests.

  Luis

      reply	other threads:[~2023-09-18 18:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-15 23:48 [RFC PATCH kdevops 0/2] augment expunge list for v6.1.53 Frederick Lawler
2023-09-15 23:48 ` [RFC PATCH kdevops 1/2] fstests/xfs: copy 6.1.42 baseline " Frederick Lawler
2023-09-15 23:48 ` [RFC PATCH kdevops 2/2] xfs: merge common expunge lists " Frederick Lawler
2023-09-16  9:23 ` [RFC PATCH kdevops 0/2] augment expunge list " Amir Goldstein
2023-09-18 18:52   ` Luis Chamberlain [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZQicb1SyQGxlxJeL@bombadil.infradead.org \
    --to=mcgrof@kernel.org \
    --cc=amir73il@gmail.com \
    --cc=chandan.babu@oracle.com \
    --cc=djwong@kernel.org \
    --cc=fred@cloudflare.com \
    --cc=kdevops@lists.linux.dev \
    --cc=kernel-team@cloudflare.com \
    --cc=leah.rumancik@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).