kdevops.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [PATCH] qemu-build: Fix variable nproc undefined error
@ 2023-08-25 17:08 fan.ni
  2023-08-25 17:14 ` Jeff Layton
  0 siblings, 1 reply; 2+ messages in thread
From: fan.ni @ 2023-08-25 17:08 UTC (permalink / raw)
  To: jlayton; +Cc: nmtadam.samsung, fan.ni, kdevops, mcgrof, Fan Ni

From: Fan Ni <fan.ni@gmx.us>

When running make qemu-build, hit the issue (msg": "The task includes an
option with an undefined variable. The error was: 'nproc' is undefined.
'nproc' is undefined\n\nThe error appears to be in ...").

Fixed it by adding "build" tag to Get nproc.

Suggested-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Fan Ni <fan.ni@samsung.com>
---
 playbooks/roles/build_qemu/tasks/main.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/playbooks/roles/build_qemu/tasks/main.yml b/playbooks/roles/build_qemu/tasks/main.yml
index 6bd34cf4..d3427c56 100644
--- a/playbooks/roles/build_qemu/tasks/main.yml
+++ b/playbooks/roles/build_qemu/tasks/main.yml
@@ -83,7 +83,7 @@

 - name: Get nproc
   command: "{{ num_jobs }}"
-  tags: [ 'qemu', 'configure' ]
+  tags: [ 'qemu', 'configure', 'build' ]
   register: nproc
   when:
     - build_qemu_now|bool
--
2.40.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] qemu-build: Fix variable nproc undefined error
  2023-08-25 17:08 [PATCH] qemu-build: Fix variable nproc undefined error fan.ni
@ 2023-08-25 17:14 ` Jeff Layton
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Layton @ 2023-08-25 17:14 UTC (permalink / raw)
  To: fan.ni; +Cc: nmtadam.samsung, fan.ni, kdevops, mcgrof

On Fri, 2023-08-25 at 10:08 -0700, fan.ni@gmx.us wrote:
> From: Fan Ni <fan.ni@gmx.us>
> 
> When running make qemu-build, hit the issue (msg": "The task includes an
> option with an undefined variable. The error was: 'nproc' is undefined.
> 'nproc' is undefined\n\nThe error appears to be in ...").
> 
> Fixed it by adding "build" tag to Get nproc.
> 
> Suggested-by: Jeff Layton <jlayton@kernel.org>
> Signed-off-by: Fan Ni <fan.ni@samsung.com>
> ---
>  playbooks/roles/build_qemu/tasks/main.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/playbooks/roles/build_qemu/tasks/main.yml b/playbooks/roles/build_qemu/tasks/main.yml
> index 6bd34cf4..d3427c56 100644
> --- a/playbooks/roles/build_qemu/tasks/main.yml
> +++ b/playbooks/roles/build_qemu/tasks/main.yml
> @@ -83,7 +83,7 @@
> 
>  - name: Get nproc
>    command: "{{ num_jobs }}"
> -  tags: [ 'qemu', 'configure' ]
> +  tags: [ 'qemu', 'configure', 'build' ]
>    register: nproc
>    when:
>      - build_qemu_now|bool
> --
> 2.40.1
> 

Thanks! Pushed to master.
-- 
Jeff Layton <jlayton@kernel.org>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-08-25 17:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-25 17:08 [PATCH] qemu-build: Fix variable nproc undefined error fan.ni
2023-08-25 17:14 ` Jeff Layton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).