From: Marc Zyngier <maz@kernel.org>
To: Oscar Carter <oscar.carter@gmx.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Kees Cook <keescook@chromium.org>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>, Len Brown <lenb@kernel.org>,
kernel-hardening@lists.openwall.com,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH v5 0/3] drivers/acpi: Remove function callback casts
Date: Fri, 26 Jun 2020 14:07:20 +0100 [thread overview]
Message-ID: <07911cc62ef21900c43aeefbcbfc8d9f@kernel.org> (raw)
In-Reply-To: <20200530143430.5203-1-oscar.carter@gmx.com>
Hi Rafael,
On 2020-05-30 15:34, Oscar Carter wrote:
> In an effort to enable -Wcast-function-type in the top-level Makefile
> to
> support Control Flow Integrity builds, there are the need to remove all
> the function callback casts in the acpi driver.
>
> The first patch creates a macro called
> ACPI_DECLARE_SUBTABLE_PROBE_ENTRY
> to initialize the acpi_probe_entry struct using the probe_subtbl field
> instead of the probe_table field to avoid function cast mismatches.
>
> The second patch modifies the IRQCHIP_ACPI_DECLARE macro to use the new
> defined macro ACPI_DECLARE_SUBTABLE_PROBE_ENTRY instead of the macro
> ACPI_DECLARE_PROBE_ENTRY. Also, modifies the prototype of the functions
> used by the invocation of the IRQCHIP_ACPI_DECLARE macro to match all
> the
> parameters.
>
> The third patch removes the function cast in the
> ACPI_DECLARE_PROBE_ENTRY
> macro to ensure that the functions passed as a last parameter to this
> macro
> have the right prototype. This macro is used only in another macro
> called "TIMER_ACPI_DECLARE". An this is used only in the file:
>
> drivers/clocksource/arm_arch_timer.c
>
> In this file, the function used in the last parameter of the
> TIMER_ACPI_DECLARE macro already has the right prototype. So there is
> no
> need to modify its prototype.
I'd like to see this into 5.9. Can you please let me know if
you are OK with the acpi.h changes? I can queue it via the irqchip
tree.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2020-06-26 13:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-30 14:34 [PATCH v5 0/3] drivers/acpi: Remove function callback casts Oscar Carter
2020-05-30 14:34 ` [PATCH v5 1/3] drivers/acpi: Add new macro ACPI_DECLARE_SUBTABLE_PROBE_ENTRY Oscar Carter
2020-05-30 14:34 ` [PATCH v5 2/3] drivers/irqchip: Use " Oscar Carter
2020-05-30 14:34 ` [PATCH v5 3/3] drivers/acpi: Remove function cast Oscar Carter
2020-06-26 13:07 ` Marc Zyngier [this message]
2020-06-26 13:17 ` [PATCH v5 0/3] drivers/acpi: Remove function callback casts Rafael J. Wysocki
2020-06-27 11:08 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07911cc62ef21900c43aeefbcbfc8d9f@kernel.org \
--to=maz@kernel.org \
--cc=jason@lakedaemon.net \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oscar.carter@gmx.com \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).