From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEDF1C76186 for ; Wed, 17 Jul 2019 10:01:47 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id 129E020818 for ; Wed, 17 Jul 2019 10:01:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 129E020818 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-16504-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 7768 invoked by uid 550); 17 Jul 2019 10:01:39 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 7710 invoked from network); 17 Jul 2019 10:01:38 -0000 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,273,1559545200"; d="scan'208";a="366513879" From: "Gote, Nitin R" To: Kees Cook , Vegard Nossum CC: "kernel-hardening@lists.openwall.com" Subject: RE: Regarding have kfree() (and related) set the pointer to NULL too Thread-Topic: Regarding have kfree() (and related) set the pointer to NULL too Thread-Index: AQHVLN3/1onQPuLQW0enNiTmJ7gvZKavUt8AgA67ihCAEGjE0A== Date: Wed, 17 Jul 2019 10:01:21 +0000 Message-ID: <12356C813DFF6F479B608F81178A561587A39C@BGSMSX101.gar.corp.intel.com> References: <12356C813DFF6F479B608F81178A561586BDFE@BGSMSX101.gar.corp.intel.com> <201906270908.28E5E1FDC3@keescook> <12356C813DFF6F479B608F81178A5615875DA9@BGSMSX101.gar.corp.intel.com> In-Reply-To: <12356C813DFF6F479B608F81178A5615875DA9@BGSMSX101.gar.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTI5NWJjNTctMzFkZC00ODkxLTg4NDYtMjg3ZjY2YTVmYmEzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiK1hWXC9DZUxSMlo4Rzhhc3kwRFNBMllDTW5TNXFvZFVESXY3ZHVRdjlcLzBQcjZ0MUI4QktEeUJsbWlYMTNVcElZIn0= x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 PiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4gRnJvbTogS2VlcyBDb29rIFttYWls dG86a2Vlc2Nvb2tAY2hyb21pdW0ub3JnXQ0KPiA+IFNlbnQ6IFRodXJzZGF5LCBKdW5lIDI3LCAy MDE5IDk6NTIgUE0NCj4gPiBUbzogVmVnYXJkIE5vc3N1bSA8dmVnYXJkLm5vc3N1bUBnbWFpbC5j b20+DQo+ID4gQ2M6IEdvdGUsIE5pdGluIFIgPG5pdGluLnIuZ290ZUBpbnRlbC5jb20+OyBrZXJu ZWwtDQo+ID4gaGFyZGVuaW5nQGxpc3RzLm9wZW53YWxsLmNvbQ0KPiA+IFN1YmplY3Q6IFJlOiBS ZWdhcmRpbmcgaGF2ZSBrZnJlZSgpIChhbmQgcmVsYXRlZCkgc2V0IHRoZSBwb2ludGVyIHRvDQo+ ID4gTlVMTCB0b28NCj4gPg0KPiA+IE9uIFRodSwgSnVuIDI3LCAyMDE5IGF0IDAxOjQ1OjA2UE0g KzAyMDAsIFZlZ2FyZCBOb3NzdW0gd3JvdGU6DQo+ID4gPiBPbiBUaHUsIDI3IEp1biAyMDE5IGF0 IDEyOjIzLCBHb3RlLCBOaXRpbiBSIDxuaXRpbi5yLmdvdGVAaW50ZWwuY29tPg0KPiB3cm90ZToN Cj4gPiA+ID4gSGksDQo+ID4gPiA+DQo+ID4gPiA+IEnigJltIGxvb2tpbmcgIGludG8g4oCcaGF2 ZSBrZnJlZSgpIChhbmQgcmVsYXRlZCkgc2V0IHRoZSBwb2ludGVyIHRvIE5VTEwgdG9v4oCdDQo+ ID4gdGFzay4NCj4gPiA+ID4NCj4gPiA+ID4gQXMgcGVyIG15IHVuZGVyc3RhbmRpbmcsIEkgZGlk IGJlbG93IGNoYW5nZXMgOg0KPiA+ID4gPg0KPiA+ID4gPiBDb3VsZCB5b3UgcGxlYXNlIHByb3Zp ZGUgc29tZSBwb2ludHMgb24gYmVsb3cgd2F5cyA/DQo+ID4gPiA+IEBAIC0zNzU0LDYgKzM3NTQs NyBAQCB2b2lkIGtmcmVlKGNvbnN0IHZvaWQgKm9ianApDQo+ID4gPiA+ICAgICAgICAgZGVidWdf Y2hlY2tfbm9fb2JqX2ZyZWVkKG9ianAsIGMtPm9iamVjdF9zaXplKTsNCj4gPiA+ID4gICAgICAg ICBfX2NhY2hlX2ZyZWUoYywgKHZvaWQgKilvYmpwLCBfUkVUX0lQXyk7DQo+ID4gPiA+ICAgICAg ICAgbG9jYWxfaXJxX3Jlc3RvcmUoZmxhZ3MpOw0KPiA+ID4gPiArICAgICAgIG9ianAgPSBOVUxM Ow0KPiA+ID4gPg0KPiA+ID4gPiB9DQo+ID4gPg0KPiA+ID4gVGhpcyB3aWxsIG5vdCBkbyBhbnl0 aGluZywgc2luY2UgdGhlIGFzc2lnbm1lbnQgaGFwcGVucyB0byB0aGUgbG9jYWwNCj4gPiA+IHZh cmlhYmxlIGluc2lkZSBrZnJlZSgpIHJhdGhlciB0aGFuIHRvIHRoZSBvcmlnaW5hbCBleHByZXNz aW9uIHRoYXQNCj4gPiA+IHdhcyBwYXNzZWQgdG8gaXQgYXMgYW4gYXJndW1lbnQuDQo+ID4gPg0K PiA+ID4gQ29uc2lkZXIgdGhhdCB0aGUgY29kZSBpbiB0aGUgY2FsbGVyIGxvb2tzIGxpa2UgdGhp czoNCj4gPiA+DQo+ID4gPiB2b2lkICp4ID0ga21hbGxvYyguLi4pOw0KPiA+ID4ga2ZyZWUoeCk7 DQo+ID4gPiBwcl9pbmZvKCJ4ID0gJXBcbiIsIHgpOw0KPiA+ID4NCj4gPiA+IHRoaXMgd2lsbCBz dGlsbCBwcmludCAieCA9IChzb21lIG5vbi1OVUxMIGFkZHJlc3MpIiBiZWNhdXNlIHRoZQ0KPiA+ ID4gdmFyaWFibGUgJ3gnIGluIHRoZSBjYWxsZXIgc3RpbGwgcmV0YWlucyBpdHMgb3JpZ2luYWwg dmFsdWUuDQo+ID4gPg0KPiA+ID4gWW91IGNvdWxkIHRyeSB3cmFwcGluZyBrZnJlZSgpIGluIGEg QyBtYWNybywgc29tZXRoaW5nIGxpa2UNCj4gPiA+DQo+ID4gPiAjZGVmaW5lIGtmcmVlKHgpIHJl YWxfa2ZyZWUoeCk7ICh4KSA9IE5VTEw7DQo+ID4NCj4gPiBSaWdodCwgdGhvdWdoIHdlIHdhbnQg dG8gYXZvaWQgc2lsZW50IGRvdWJsZS1ldmFsdWF0aW9uLCBzbyB3ZSBoYXZlIHRvDQo+ID4gZG8g c29tZSBtYWNybyB0cmlja3MuIEkgc3VzcGVjdCB0aGUgc3RhcnRpbmcgcG9pbnQgaXMgc29tZXRo aW5nIGxpa2U6DQo+ID4NCj4gPiAjZGVmaW5lIGtmcmVlKHgpCQkJXA0KPiA+IAlkbyB7CQkJCVwN Cj4gPiAJCXR5cGVvZih4KSAqcHRyID0gJih4KTsJXA0KPiA+IAkJcmVhbF9rZnJlZSgqcHRyKTsJ XA0KPiA+IAkJKnB0ciA9IE5VTEw7CQlcDQo+ID4gCX0gd2hpbGUgKDApDQo+ID4NCj4gPiBIb3dl dmVyLCB0aGVyZSBhcmUgYSBub24temVybyBudW1iZXIgb2YgcGxhY2VzIGluIHRoZSBrZXJuZWwg d2hlcmUNCj4gPiBrZnJlZSgpIGlzIHVzZWQgb24gdGhpbmdzIHRoYXQgYXJlIG5vdCBzaW1wbGUg bWVtb3J5IHJlZmVyZW5jZXMsIGxpa2UNCj4gPiBmdW5jdGlvbiByZXR1cm4gdmFsdWVzLCBvciBj b3BpZXMgb2YgdGhlIGFjdHVhbCByZWZlcmVuY2U6DQo+ID4NCj4gPiAJa2ZyZWUoZ2V0X215X2Fs bG9jYXRpb24oZm9vKSk7DQo+ID4NCg0KV2UgaGF2ZSBub3QgZm91bmQgYW55IGNsdWUgb3IgY29t cGlsZXIgZXh0ZW5zaW9uIG9uIHRoaXMgY2FzZSB0byBrbm93IHggDQppcyB2YWx1ZSBvciB2YXJp YWJsZS4NCg0KVGhlcmUgYXJlIGFyb3VuZCAzMDAgc3VjaCBjYXNlcyBpbiBrZXJuZWwgd2hlcmUg a2ZyZWUoKSBpcyB1c2VkIG9uIGZ1bmN0aW9uIHJldHVybiB2YWx1ZXMuIA0KDQpPbmUgcHJvcG9z YWwgaXMgd2UgY2FuIHJlZmFjdG9yIHRoZSBrZnJlZSgpIGNhbGwgYnkgYXNzaWduaW5nIGl0IHRv IGxvY2FsIHZhcmlhYmxlIHNvIHRoYXQNCndlIGNhbiBvdmVyY29tZSB0aGUgY29tcGlsYXRpb24g aXNzdWUgKGVycm9yOiBsdmFsdWUgcmVxdWlyZWQgYXMgdW5hcnkgJiBvcGVyYW5kKS4NCg0KUGxl YXNlIGxldCB1cyBrbm93IHRoYXQgd2Ugc2hvdWxkIHByb2NlZWQgd2l0aCB0aGlzIHByb3Bvc2Fs IG9yIHlvdSAob3IgYW55b25lKQ0KaGF2ZSBvdGhlciBwcm9wb3NhbHMuDQoNCj4gPiBvcg0KPiA+ DQo+ID4gCXByZXZpb3VzID0gc29tZXRoaW5nLT5hbGxvY2F0aW9uOw0KPiA+IAkuLi4NCj4gPiAJ a2ZyZWUocHJldmlvdXMpDQo+ID4NCg0KQXMgb2Ygbm93LCB3ZSBkb24ndCBoYXZlIGFueSBpZGVh IHRvIG92ZXJjb21lIHRoaXMgY2FzZS4gDQpTbywgd2UgYXJlIGtlZXBpbmcgdGhpcyBmb3IgbGF0 ZXIgc3RhZ2UuIA0KDQpJbiBjYXNlIGFueW9uZSBoYXMgaWRlYSBvbiB0aGlzIHRoZW4gbGV0IG1l IGtub3csIA0Kd2UgYXJlIHJlYWR5IHRvIHdvcmsgb24gdGhpcy4gDQoNCj4gPiBTbyB0aGUgbGFy Z2VyIHdvcmsgaXMgZmlndXJpbmcgb3V0IGhvdyB0byBncmFjZWZ1bGx5IGRlYWwgd2l0aCB0aG9z ZQ0KPiA+IHVzaW5nIGEgcmVhc29uYWJsZSBBUEksIG9yIHRocm91Z2ggcmVmYWN0b3JpbmcuDQo+ ID4NCj4gPiBIb3dldmVyLCBiZWZvcmUgZ2V0dGluZyB0b28gZmFyLCBpdCdzIHdvcnRoIGdvaW5n IHRob3VnaCBwYXN0DQo+ID4gdXNlLWFmdGVyLWZyZWUgdnVsbmVyYWJpbGl0aWVzIHRvIGZpZ3Vy ZSBvdXQgaG93IG1hbnkgd291bGQgaGF2ZSBiZWVuDQo+ID4gcmVuZGVyZWQgaGFybWxlc3MgKE5V TEwgZGVyZWYgaW5zdGVhZCBvZiBVYUYpIHdpdGggdGhpcyBjaGFuZ2UuIEhhcw0KPiA+IHRoaXMg YmVlbiBzdHVkaWVkIGJlZm9yZSwgZXRjLiBXaXRoIHRoaXMgaW5mb3JtYXRpb24gaXQncyBlYXNp ZXIgdG8NCj4gPiBkZWNpZGUgaWYgdGhlIGJlbmVmaXQgb2YgdGhpcyByZWZhY3RvcmluZyBpcyB3 b3J0aCB0aGUgd29yayB0byBkbyBpdC4NCj4gPg0KDQpUaGFua3MsDQpOaXRpbg0KDQo=