From mboxrd@z Thu Jan 1 00:00:00 1970 Reply-To: kernel-hardening@lists.openwall.com From: Jason Cooper Date: Sat, 30 Jul 2016 15:42:37 +0000 Message-Id: <20160730154244.403-1-jason@lakedaemon.net> In-Reply-To: <20160728204730.27453-1-jason@lakedaemon.net> References: <20160728204730.27453-1-jason@lakedaemon.net> Subject: [kernel-hardening] [PATCH v2 0/7] char/random: Simplify random address requests To: william.c.roberts@intel.com, Yann Droneaud , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-hardening@lists.openwall.com Cc: linux@arm.linux.org.uk, akpm@linux-foundation.org, keescook@chromium.org, tytso@mit.edu, arnd@arndb.de, gregkh@linuxfoundation.org, catalin.marinas@arm.com, will.deacon@arm.com, ralf@linux-mips.org, benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, viro@zeniv.linux.org.uk, nnk@google.com, jeffv@google.com, dcashman@android.com, Jason Cooper List-ID: Two previous attempts have been made to rework this API. The first can be found at: https://lkml.kernel.org/r/cover.1390770607.git.ydroneaud@opteya.com The second at: https://lkml.kernel.org/r/1469471141-25669-1-git-send-email-william.c.roberts@intel.com The RFC version of this series can been seen at: https://lkml.kernel.org/r/20160726030201.6775-1-jason@lakedaemon.net In addition to incorporating ideas from these two previous efforts, this series adds several desirable features. First, we take the range as an argument directly, which removes math both before the call and inside the function. Second, we return the start address on error. All callers fell back to the start address on error, so we remove the need to check for errors. Third, we cap range to prevent overflow. Last, we use kerneldoc to describe the new function. If possible, I'd like to request Acks from the various subsystems so that we can merge this as one bisectable branch. Changes from v1: - Explicitly mention page_aligned start assumption (Yann Droneaud) - pick random pages vice random addresses (Yann Droneaud) - catch range=0 last - Add Ack for arm64 (Will Deacon) Jason Cooper (7): random: Simplify API for random address requests x86: Use simpler API for random address requests ARM: Use simpler API for random address requests arm64: Use simpler API for random address requests tile: Use simpler API for random address requests unicore32: Use simpler API for random address requests random: Remove unused randomize_range() arch/arm/kernel/process.c | 3 +-- arch/arm64/kernel/process.c | 8 ++------ arch/tile/mm/mmap.c | 3 +-- arch/unicore32/kernel/process.c | 3 +-- arch/x86/kernel/process.c | 3 +-- arch/x86/kernel/sys_x86_64.c | 5 +---- drivers/char/random.c | 31 ++++++++++++++++++++----------- include/linux/random.h | 2 +- 8 files changed, 28 insertions(+), 30 deletions(-) -- 2.9.2