From: Matthew Wilcox <willy@infradead.org>
To: Kees Cook <keescook@chromium.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Rik van Riel <riel@surriel.com>, Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Kernel Hardening <kernel-hardening@lists.openwall.com>,
Michael Ellerman <mpe@ellerman.id.au>
Subject: Re: [PATCH] mm: Prevent mapping slab pages to userspace
Date: Fri, 25 Jan 2019 11:30:04 -0800 [thread overview]
Message-ID: <20190125193004.GA21155@bombadil.infradead.org> (raw)
In-Reply-To: <CAGXu5jJ=yHXC_S_o6V4QQ+DCV4w2T-tw_BiUXDAW2a8rZDhZJg@mail.gmail.com>
On Sat, Jan 26, 2019 at 07:44:40AM +1300, Kees Cook wrote:
> > - if (PageAnon(page))
> > + if (PageAnon(page) || PageSlab(page))
>
> Are there other types that should not get mapped? (Or better yet, is
> there a whitelist of those that are okay to be mapped?)
Funny you should ask; I think the next patch in this series looks like this:
- if (PageAnon(page) || PageSlab(page))
+ if (PageAnon(page) || PageSlab(page) || page_has_type(page))
but let's see if there's something I've overlooked with this patch.
next prev parent reply other threads:[~2019-01-25 19:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 17:38 [PATCH] mm: Prevent mapping slab pages to userspace Matthew Wilcox
2019-01-25 18:44 ` Kees Cook
2019-01-25 19:30 ` Matthew Wilcox [this message]
2019-01-28 18:20 ` Andrew Morton
2019-01-28 19:00 ` Kees Cook
2019-01-28 20:08 ` Christopher Lameter
2019-01-31 0:37 ` Michael Ellerman
2019-01-31 6:03 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190125193004.GA21155@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpe@ellerman.id.au \
--cc=penberg@kernel.org \
--cc=riel@surriel.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).