From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 30 Jan 2019 09:28:57 +0100 From: Greg Kroah-Hartman Subject: Re: [PATCH] tty: ldisc: add sysctl to prevent autoloading of ldiscs Message-ID: <20190130082857.GB24317@kroah.com> References: <20190121162642.GA2944@kroah.com> <20190122000142.GB19379@mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190122000142.GB19379@mit.edu> To: "Theodore Y. Ts'o" , kernel-hardening@lists.openwall.com, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Jiri Slaby List-ID: On Mon, Jan 21, 2019 at 07:01:42PM -0500, Theodore Y. Ts'o wrote: > On Mon, Jan 21, 2019 at 05:26:42PM +0100, Greg Kroah-Hartman wrote: > > By default, the kernel will automatically load the module of any line > > dicipline that is asked for. As this sometimes isn't the safest thing > > to do, provide a sysctl to disable this feature. > > > > By default, we set this to 'y' as that is the historical way that Linux > > has worked, and we do not want to break working systems. But in the > > future, perhaps this can default to 'n' to prevent this functionality. > > > > Signed-off-by: Greg Kroah-Hartman > > Reviewed-by: Theodore Ts'o Thanks for the review!