From: "Tobin C. Harding" <me@tobin.cc>
To: David Laight <David.Laight@aculab.com>
Cc: "'Tobin C. Harding'" <tobin@kernel.org>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>,
Tycho Andersen <tycho@tycho.ws>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] leaking_addresses: Expand tilde in output file name
Date: Thu, 14 Feb 2019 07:30:33 +1100 [thread overview]
Message-ID: <20190213203033.GB31743@eros.localdomain> (raw)
In-Reply-To: <6aed136f16e8451dbcfa97f90c04438f@AcuMS.aculab.com>
On Wed, Feb 13, 2019 at 03:56:47PM +0000, David Laight wrote:
> From: Tobin C. Harding
> > Sent: 07 February 2019 22:50
> >
> > Currently if user passes an output file to the script via
> > --output-raw we do not handle expansion of tilde.
> >
> > Use perl function glob() to expand tilde in output file name.
>
> What happens if glob() returns multiple files?
> I'm guessing that it can...
Thanks for taking a look at this David. Surely glob() cannot return
multiple values when expanding tilde? If someone passes a '*' into the
command as an input/output file then they are clearly mad :)
thanks,
Tobin.
next prev parent reply other threads:[~2019-02-13 20:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 22:50 [PATCH 0/3] Minor bug fixes to leaking_addresses.pl Tobin C. Harding
2019-02-07 22:50 ` [PATCH 1/3] leaking_addresses: Fix calls to dprint Tobin C. Harding
2019-02-07 22:50 ` [PATCH 2/3] leaking_addresses: Completely remove --version flag Tobin C. Harding
2019-02-07 22:50 ` [PATCH 3/3] leaking_addresses: Expand tilde in output file name Tobin C. Harding
2019-02-07 23:35 ` Tycho Andersen
2019-02-09 6:01 ` Tobin C. Harding
2019-02-14 4:13 ` Tobin C. Harding
2019-02-13 15:56 ` David Laight
2019-02-13 20:30 ` Tobin C. Harding [this message]
2019-02-14 9:50 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213203033.GB31743@eros.localdomain \
--to=me@tobin.cc \
--cc=David.Laight@aculab.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tobin@kernel.org \
--cc=tycho@tycho.ws \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).