From: Mark Rutland <mark.rutland@arm.com>
To: Alexander Potapenko <glider@google.com>
Cc: yamada.masahiro@socionext.com, jmorris@namei.org,
serge@hallyn.com, linux-security-module@vger.kernel.org,
linux-kbuild@vger.kernel.org, ndesaulniers@google.com,
kcc@google.com, dvyukov@google.com, keescook@chromium.org,
sspatil@android.com, kernel-hardening@lists.openwall.com
Subject: Re: [PATCH v3 2/2] initmem: introduce CONFIG_INIT_ALL_HEAP
Date: Tue, 9 Apr 2019 10:32:35 +0100 [thread overview]
Message-ID: <20190409093234.GB21979@lakrids.cambridge.arm.com> (raw)
In-Reply-To: <20190408170418.148554-3-glider@google.com>
On Mon, Apr 08, 2019 at 07:04:18PM +0200, Alexander Potapenko wrote:
> This config option enables CONFIG_SLUB_DEBUG and CONFIG_PAGE_POISONING
> without the need to pass any boot parameters.
>
> No performance optimizations are done at the moment to reduce double
> initialization of memory regions.
>
> Signed-off-by: Alexander Potapenko <glider@google.com>
> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> Cc: James Morris <jmorris@namei.org>
> Cc: "Serge E. Hallyn" <serge@hallyn.com>
> Cc: Nick Desaulniers <ndesaulniers@google.com>
> Cc: Kostya Serebryany <kcc@google.com>
> Cc: Dmitry Vyukov <dvyukov@google.com>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Sandeep Patil <sspatil@android.com>
> Cc: linux-security-module@vger.kernel.org
> Cc: linux-kbuild@vger.kernel.org
> Cc: kernel-hardening@lists.openwall.com
> ---
> v3:
> - addressed comments by Masahiro Yamada (Kconfig fixes)
> ---
> mm/page_poison.c | 5 +++++
> mm/slub.c | 2 ++
> security/Kconfig.initmem | 11 +++++++++++
> 3 files changed, 18 insertions(+)
>
> diff --git a/mm/page_poison.c b/mm/page_poison.c
> index 21d4f97cb49b..a1985f33f635 100644
> --- a/mm/page_poison.c
> +++ b/mm/page_poison.c
> @@ -12,9 +12,14 @@ static bool want_page_poisoning __read_mostly;
>
> static int __init early_page_poison_param(char *buf)
> {
> +#ifdef CONFIG_INIT_ALL_HEAP
> + want_page_poisoning = true;
> + return 0;
> +#else
> if (!buf)
> return -EINVAL;
> return strtobool(buf, &want_page_poisoning);
> +#endif
> }
> early_param("page_poison", early_page_poison_param);
IIUC this is only called if page_poison is passed on the command line,
so want_page_poisoning won't be set automatically unless that's passed.
Presumably you want to initialize it at definition with:
static bool want_page_poisoning __read_mostly = IS_ENABLED(CONFIG_INIT_ALL_HEAP);
with:
#ifndef CONFIG_INIT_ALL_HEAP
static int __init early_page_poison_param(char *buf)
{
...
}
early_param("page_poison", early_page_poison_param);
#endif
... so that it can't be disabled?
Thanks,
Mark.
next prev parent reply other threads:[~2019-04-09 9:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 17:04 [PATCH v3 0/2] RFC: introduce CONFIG_INIT_ALL_MEMORY Alexander Potapenko
2019-04-08 17:04 ` [PATCH v3 1/2] initmem: introduce CONFIG_INIT_ALL_MEMORY and CONFIG_INIT_ALL_STACK Alexander Potapenko
2019-04-08 22:15 ` Randy Dunlap
2019-04-09 8:29 ` Alexander Potapenko
2019-04-09 8:37 ` Masahiro Yamada
2019-04-09 9:02 ` Alexander Potapenko
2019-04-09 9:03 ` Alexander Potapenko
2019-04-09 17:06 ` Kees Cook
2019-04-08 17:04 ` [PATCH v3 2/2] initmem: introduce CONFIG_INIT_ALL_HEAP Alexander Potapenko
2019-04-08 17:39 ` Jann Horn
2019-04-09 9:32 ` Mark Rutland [this message]
2019-04-09 9:53 ` Alexander Potapenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190409093234.GB21979@lakrids.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=jmorris@namei.org \
--cc=kcc@google.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=ndesaulniers@google.com \
--cc=serge@hallyn.com \
--cc=sspatil@android.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).