From: Steven Rostedt <rostedt@goodmis.org>
To: "Joel Fernandes (Google)" <joel@joelfernandes.org>
Cc: linux-kernel@vger.kernel.org, paulmck@linux.vnet.ibm.com,
keescook@chromium.org, Jessica Yu <jeyu@kernel.org>,
kernel-hardening@lists.openwall.com, kernel-team@android.com,
mathieu.desnoyers@efficios.com, rcu@vger.kernel.org
Subject: Re: [PATCH 2/2] module: Make srcu_struct ptr array as read-only post init
Date: Tue, 9 Apr 2019 22:38:20 -0400 [thread overview]
Message-ID: <20190409223820.511e3671@oasis.local.home> (raw)
In-Reply-To: <20190410011418.76408-2-joel@joelfernandes.org>
On Tue, 9 Apr 2019 21:14:18 -0400
"Joel Fernandes (Google)" <joel@joelfernandes.org> wrote:
> /*
> - * Mark ro_after_init section with SHF_RO_AFTER_INIT so that
> + * These are section names marked with SHF_RO_AFTER_INIT so that
I'm curious to this much of a change. Wouldn't just making "section"
plural also work?
"Mark ro_after_init sections with ..."
Other than that, the two patches look fine to me.
-- Steve
> * layout_sections() can put it in the right place.
> * Note: ro_after_init sections also have SHF_{WRITE,ALLOC} set.
> */
> @@ -3314,6 +3314,13 @@ static char *ro_after_init_sections[] = {
next prev parent reply other threads:[~2019-04-10 2:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 1:14 [PATCH 1/2] module: Prepare for addition of new ro_after_init sections Joel Fernandes (Google)
2019-04-10 1:14 ` [PATCH 2/2] module: Make srcu_struct ptr array as read-only post init Joel Fernandes (Google)
2019-04-10 1:17 ` Joel Fernandes
2019-04-10 2:38 ` Steven Rostedt [this message]
2019-04-10 2:41 ` Joel Fernandes
2019-04-10 2:48 ` Steven Rostedt
2019-04-10 3:38 ` Joel Fernandes
2019-04-10 4:20 ` Mathieu Desnoyers
2019-04-10 16:26 ` [PATCH 1/2] module: Prepare for addition of new ro_after_init sections Kees Cook
2019-04-10 17:48 ` Joel Fernandes
2019-04-10 18:21 ` Kees Cook
2019-04-10 18:24 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190409223820.511e3671@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=jeyu@kernel.org \
--cc=joel@joelfernandes.org \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rcu@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).