From: Romain Perier <romain.perier@gmail.com>
To: Kees Cook <keescook@chromium.org>, kernel-hardening@lists.openwall.com
Subject: Re: refactor tasklets to avoid unsigned long argument
Date: Thu, 29 Aug 2019 20:13:21 +0200 [thread overview]
Message-ID: <20190829181321.GA6213@debby.home> (raw)
In-Reply-To: <20190812172951.GA5361@debby.home>
[-- Attachment #1: Type: text/plain, Size: 1032 bytes --]
On Mon, Aug 12, 2019 at 07:29:51PM +0200, Romain Perier wrote:
Hi !
https://salsa.debian.org/rperier-guest/linux-tree/tree/tasklet_init
It is mostly done ! I have just finished the commit for removing the data field
... and... I have completly forgot the macro DECLARE_TASKLET() :=D . Well, it
is not a big issue because there are only few calls.
What I can do is the following:
1. After the commit that convert all tasklet_init() to tasklet_setup(),
I can a new commit that modifies the content of DECLARE_TASKLET()
(pass the pointer of the callback as .data) and convert the callback of all
DECLARE_TASKLET() for handling the argument with from_tasklet() correctly
2. Then the commit for removing the .data field in the tasklet_struct
structure that also removes the data field in DECLARE_TASKLET() (without
changing the API of the macro, I just remove the field data from the
content of the macro)
3. Change the API of DECLARE_TASKLET() and update all calls in a single
shot
What do you think ?
Thanks,
Regards,
Romain
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-08-29 18:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 7:35 refactor tasklets to avoid unsigned long argument Romain Perier
2019-07-02 15:51 ` Kees Cook
2019-07-03 15:48 ` Romain Perier
2019-07-03 22:46 ` Kees Cook
2019-07-21 17:55 ` Romain Perier
2019-07-22 17:19 ` Kees Cook
2019-07-23 8:15 ` Romain Perier
2019-08-08 15:47 ` Romain Perier
2019-08-08 21:02 ` Kees Cook
2019-08-12 17:29 ` Romain Perier
2019-08-29 18:13 ` Romain Perier [this message]
2019-08-29 18:35 ` Kees Cook
2019-09-29 16:37 ` Romain Perier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190829181321.GA6213@debby.home \
--to=romain.perier@gmail.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).