From: kbuild test robot <lkp@intel.com>
To: Alexander Potapenko <glider@google.com>
Cc: kbuild-all@01.org, Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@linux.com>,
Alexander Potapenko <glider@google.com>,
Thibaut Sautereau <thibaut@sautereau.fr>,
Kees Cook <keescook@chromium.org>,
Laura Abbott <labbott@redhat.com>,
linux-mm@kvack.org, kernel-hardening@lists.openwall.com
Subject: Re: [PATCH v1 1/2] mm: slub: init_on_free=1 should wipe freelist ptr for bulk allocations
Date: Sat, 5 Oct 2019 02:45:27 +0800 [thread overview]
Message-ID: <201910050212.ihzBaoD7%lkp@intel.com> (raw)
In-Reply-To: <20191004132555.202973-1-glider@google.com>
[-- Attachment #1: Type: text/plain, Size: 1745 bytes --]
Hi Alexander,
I love your patch! Perhaps something to improve:
[auto build test WARNING on mmotm/master]
url: https://github.com/0day-ci/linux/commits/Alexander-Potapenko/mm-slub-init_on_free-1-should-wipe-freelist-ptr-for-bulk-allocations/20191005-012134
base: git://git.cmpxchg.org/linux-mmotm.git master
config: sparc64-allmodconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=sparc64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> mm/slub.c:2676:24: warning: return type defaults to 'int' [-Wreturn-type]
static __always_inline maybe_wipe_obj_freeptr(struct kmem_cache *s, void *obj)
^~~~~~~~~~~~~~~~~~~~~~
mm/slub.c: In function 'maybe_wipe_obj_freeptr':
>> mm/slub.c:2680:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
vim +/int +2676 mm/slub.c
2671
2672 /*
2673 * If the object has been wiped upon free, make sure it's fully initialized by
2674 * zeroing out freelist pointer.
2675 */
> 2676 static __always_inline maybe_wipe_obj_freeptr(struct kmem_cache *s, void *obj)
2677 {
2678 if (unlikely(slab_want_init_on_free(s)) && obj)
2679 memset((void *)((char *)obj + s->offset), 0, sizeof(void *));
> 2680 }
2681
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 59039 bytes --]
prev parent reply other threads:[~2019-10-04 18:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 13:25 [PATCH v1 1/2] mm: slub: init_on_free=1 should wipe freelist ptr for bulk allocations Alexander Potapenko
2019-10-04 13:25 ` [PATCH v1 2/2] lib/test_meminit: add a kmem_cache_alloc_bulk() test Alexander Potapenko
2019-10-04 18:45 ` kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201910050212.ihzBaoD7%lkp@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=glider@google.com \
--cc=kbuild-all@01.org \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=labbott@redhat.com \
--cc=linux-mm@kvack.org \
--cc=thibaut@sautereau.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).