From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E309CA9EC9 for ; Fri, 1 Nov 2019 03:46:29 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id D904E208CB for ; Fri, 1 Nov 2019 03:46:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="IJQVm+nH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D904E208CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-17210-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 17706 invoked by uid 550); 1 Nov 2019 03:46:23 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 17686 invoked from network); 1 Nov 2019 03:46:22 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ipB5k5z37+Fd8igQLbmVYrL5E9roHGbRK+wBmA4Y9yU=; b=IJQVm+nHblMlKtJOM196C6hcfBE3KUu5qTQKv0FOe/rkT2KShvxSF9ZK3miYtArp8S iCx9zhvAVMbHgtEQYP6IvQSYka4Me/BNhBXNxL6j6tLCRlIaOcOYAOppDrF9cr1jDZQa fRCejTSNEe4g/nH0rKI9uiV455M5B/EKg6M0Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ipB5k5z37+Fd8igQLbmVYrL5E9roHGbRK+wBmA4Y9yU=; b=n1BN+tuKSi89ZI6Dco0pzWdxr6EYsOqllzp1DLxIvRpjjVprqfAXSIpL5RLNIhdv8e sfEGg2AtC5bemjAWQkTmcdE36/yGn5ROF4ZutarhHIzlvcjkRjyNM88948eEMB3xV/1/ fcoXj4vghwQesYcyM4sSGFEeVn9FFLgHjIYs7wTdHawV9Ocbo0hl1Tn4b+5MMmKSauaG KObCguqz6mO2T6+qz7YkHhFHuSZNb11WpoAhITfPuT78nDIkeEoPJ5RfuedrLhULIEme qr9DT2RWVuAQr5XbKMQ4MObGJEVPo+FL5FPV5XI0ZM6znLHOFB7b2qhMuZMXga2BZ/Eb tLGA== X-Gm-Message-State: APjAAAXfd9q51ahaBXBk3w0dO9qC1dX9VN8VgIGtFrTTuF15ZVYuPC+u BQd2WUkcWZgb1stSMXqwZzws2g== X-Google-Smtp-Source: APXvYqzPevvEfpBSK+c7IiF5pLcK+obnlKmRuGuDHbGO/WB/NYdDcoJIb57F0lxIPa76vBgqS1skUA== X-Received: by 2002:a17:90a:2326:: with SMTP id f35mr12315696pje.134.1572579965327; Thu, 31 Oct 2019 20:46:05 -0700 (PDT) Date: Thu, 31 Oct 2019 20:46:03 -0700 From: Kees Cook To: samitolvanen@google.com Cc: Will Deacon , Catalin Marinas , Steven Rostedt , Masami Hiramatsu , Ard Biesheuvel , Dave Martin , Laura Abbott , Mark Rutland , Nick Desaulniers , Jann Horn , Miguel Ojeda , Masahiro Yamada , clang-built-linux@googlegroups.com, kernel-hardening@lists.openwall.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 16/17] arm64: disable SCS for hypervisor code Message-ID: <201910312046.343E275D@keescook> References: <20191018161033.261971-1-samitolvanen@google.com> <20191031164637.48901-1-samitolvanen@google.com> <20191031164637.48901-17-samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191031164637.48901-17-samitolvanen@google.com> On Thu, Oct 31, 2019 at 09:46:36AM -0700, samitolvanen@google.com wrote: > Filter out CC_FLAGS_SCS for code that runs at a different exception > level. > > Suggested-by: Steven Rostedt (VMware) > Signed-off-by: Sami Tolvanen Reviewed-by: Kees Cook -Kees > --- > arch/arm64/kvm/hyp/Makefile | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/kvm/hyp/Makefile b/arch/arm64/kvm/hyp/Makefile > index ea710f674cb6..17ea3da325e9 100644 > --- a/arch/arm64/kvm/hyp/Makefile > +++ b/arch/arm64/kvm/hyp/Makefile > @@ -28,3 +28,6 @@ GCOV_PROFILE := n > KASAN_SANITIZE := n > UBSAN_SANITIZE := n > KCOV_INSTRUMENT := n > + > +# remove the SCS flags from all objects in this directory > +KBUILD_CFLAGS := $(filter-out $(CC_FLAGS_SCS), $(KBUILD_CFLAGS)) > -- > 2.24.0.rc0.303.g954a862665-goog > -- Kees Cook