From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 089C0CA9ECE for ; Fri, 1 Nov 2019 03:56:52 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id 54E45208CB for ; Fri, 1 Nov 2019 03:56:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="J3B2kmOf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 54E45208CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-17218-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 30689 invoked by uid 550); 1 Nov 2019 03:56:45 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 30669 invoked from network); 1 Nov 2019 03:56:45 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=8r2XeG5yFjL/afEHA1efUXOPQ4O3tMgoY9LidcT6tD0=; b=J3B2kmOf3zKgvU8NNZfjzZBmIFxRSy0lZFZruLxNULA4qZjQB6y6wIjGU/654UxcSq DGZf/NBIx2XtK2v+AA+MLyDxAbIORjfYicFLhlVGCrHycRnDK8l+uJgiV67UYT7zvD9+ bcjozvh2Lkb/12B+x5PYqqYyeNoY18Xk3hg5c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8r2XeG5yFjL/afEHA1efUXOPQ4O3tMgoY9LidcT6tD0=; b=kojzg4WqGBxcAxOJns5fbmlE6tbd7SQjf9/BFMUxQuToOretcRyb6kp3bKYgYljush KbYVh5WuVR7vpR+eB5zZYTYjGHlkCSbDB3CLm76qw9YlA4EPitZcy0YRolBOt3OE5m20 bsoB8Kvt52XIzyizFaXtSQzRx9kUG0frI7lw0hFbh/xOBtIFhxFgcGGIOdcWYfEUodwK zmQCcJk/FaCTQ0J7bBjkXDC3xEUR6GYf/ZUTE4m8kBPBdQt031NuCbtvJuUnuIDEzsr6 L64O1vCp9RFLjIkkmqboFQezqYwn1YpqluwZj41QLixJrKpa87qP95OAcKO9KOvALyvA 6Etg== X-Gm-Message-State: APjAAAUiLThD3UUk21JKn0KqkkdryCKPJTwODEkHotHBrcNO41nynmcP au1VEd89baILGT7oJfyxglciHQ== X-Google-Smtp-Source: APXvYqy05XZ8Z7dJgqZ7/iJDGYhT5+3LQCw2SnVzAAPcmNQfe80zEq+KFf6BAA6Nkk5/7y2Fze7yKA== X-Received: by 2002:a17:902:d88c:: with SMTP id b12mr10325171plz.254.1572580593477; Thu, 31 Oct 2019 20:56:33 -0700 (PDT) Date: Thu, 31 Oct 2019 20:56:31 -0700 From: Kees Cook To: samitolvanen@google.com Cc: Will Deacon , Catalin Marinas , Steven Rostedt , Masami Hiramatsu , Ard Biesheuvel , Dave Martin , Laura Abbott , Mark Rutland , Nick Desaulniers , Jann Horn , Miguel Ojeda , Masahiro Yamada , clang-built-linux@googlegroups.com, kernel-hardening@lists.openwall.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 10/17] arm64: disable kretprobes with SCS Message-ID: <201910312056.328195A@keescook> References: <20191018161033.261971-1-samitolvanen@google.com> <20191031164637.48901-1-samitolvanen@google.com> <20191031164637.48901-11-samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191031164637.48901-11-samitolvanen@google.com> On Thu, Oct 31, 2019 at 09:46:30AM -0700, samitolvanen@google.com wrote: > With CONFIG_KRETPROBES, function return addresses are modified to > redirect control flow to kretprobe_trampoline. This is incompatible > with SCS. > > Signed-off-by: Sami Tolvanen Reviewed-by: Kees Cook -Kees > --- > arch/arm64/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 3f047afb982c..e7b57a8a5531 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -165,7 +165,7 @@ config ARM64 > select HAVE_STACKPROTECTOR > select HAVE_SYSCALL_TRACEPOINTS > select HAVE_KPROBES > - select HAVE_KRETPROBES > + select HAVE_KRETPROBES if !SHADOW_CALL_STACK > select HAVE_GENERIC_VDSO > select IOMMU_DMA if IOMMU_SUPPORT > select IRQ_DOMAIN > -- > 2.24.0.rc0.303.g954a862665-goog > -- Kees Cook