From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9195CC432C3 for ; Fri, 15 Nov 2019 06:16:32 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id DAB612073A for ; Fri, 15 Nov 2019 06:16:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZuuMgLeF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DAB612073A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-17372-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 4010 invoked by uid 550); 15 Nov 2019 06:16:25 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 3973 invoked from network); 15 Nov 2019 06:16:25 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573798572; bh=G+0cdXXTrcTHP5HHhkPRNjMmImcxewGysVtA+48G1lE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZuuMgLeFQzo5L2g7WgAd8skDAoeSdstO8NckalfM7LIkAEM/9Hkm9v9OWS7aNDVMH OtEDWlLHRzX8nf8i/P3Qoya1aZItzH8IAlhpCw8c3oHc9SfuSpwkKgldI0DneCpe/+ 97vWjyIfKOaEQpXgp5O1rBzfyL9oRxDYryelAJeY= Date: Fri, 15 Nov 2019 14:16:10 +0800 From: Greg Kroah-Hartman To: Kees Cook Cc: Larry Finger , Florian Schilhabel , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-hardening@lists.openwall.com, Romain Perier Subject: Re: [PATCH] staging: rtl*: Remove tasklet callback casts Message-ID: <20191115061610.GA1034830@kroah.com> References: <201911142135.5656E23@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201911142135.5656E23@keescook> User-Agent: Mutt/1.12.2 (2019-09-21) On Thu, Nov 14, 2019 at 09:39:00PM -0800, Kees Cook wrote: > In order to make the entire kernel usable under Clang's Control Flow > Integrity protections, function prototype casts need to be avoided > because this will trip CFI checks at runtime (i.e. a mismatch between > the caller's expected function prototype and the destination function's > prototype). Many of these cases can be found with -Wcast-function-type, > which found that the rtl wifi drivers had a bunch of needless function > casts. Remove function casts for tasklet callbacks in the various drivers. > > Signed-off-by: Kees Cook > --- > drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c | 3 +-- > drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c | 3 +-- > drivers/staging/rtl8188eu/include/rtl8188e_recv.h | 2 +- > drivers/staging/rtl8188eu/include/rtl8188e_xmit.h | 2 +- > drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 4 ++-- > drivers/staging/rtl8192e/rtllib_softmac.c | 7 +++---- > .../staging/rtl8192u/ieee80211/ieee80211_softmac.c | 7 +++---- > drivers/staging/rtl8192u/r8192U_core.c | 8 ++++---- > drivers/staging/rtl8712/rtl8712_recv.c | 11 +++++------ > drivers/staging/rtl8712/rtl871x_xmit.c | 5 ++--- > drivers/staging/rtl8712/rtl871x_xmit.h | 2 +- > drivers/staging/rtl8712/usb_ops_linux.c | 4 ++-- > drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 11 ++++------- > 13 files changed, 30 insertions(+), 39 deletions(-) This fails to apply to my staging-next branch of staging.git. Can you rebase and resend? thanks, greg k-h