Kernel-hardening archive on
 help / color / Atom feed
From: Eric Biggers <>
To: Kees Cook <>
Cc: "Herbert Xu" <>,
	"João Moreira" <>,
	"Ard Biesheuvel" <>,
	"Sami Tolvanen" <>,
	"Stephan Mueller" <>,,,,
Subject: Re: [PATCH v7] crypto: x86: Regularize glue function prototypes
Date: Wed, 27 Nov 2019 10:01:25 -0800
Message-ID: <20191127180125.GA49214@sol.localdomain> (raw)
In-Reply-To: <201911262205.FD985935F@keescook>

On Tue, Nov 26, 2019 at 10:08:02PM -0800, Kees Cook wrote:
> The crypto glue performed function prototype casting via macros to make
> indirect calls to assembly routines. Instead of performing casts at the
> call sites (which trips Control Flow Integrity prototype checking), switch
> each prototype to a common standard set of arguments which allows the
> removal of the existing macros. In order to keep pointer math unchanged,
> internal casting between u128 pointers and u8 pointers is added.
> Co-developed-by: João Moreira <>
> Signed-off-by: João Moreira <>
> Signed-off-by: Kees Cook <>

Reviewed-by: Eric Biggers <>

- Eric

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-27  6:08 Kees Cook
2019-11-27 18:01 ` Eric Biggers [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191127180125.GA49214@sol.localdomain \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Kernel-hardening archive on

Archives are clonable:
	git clone --mirror kernel-hardening/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 kernel-hardening kernel-hardening/ \
	public-inbox-index kernel-hardening

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone