From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1E20C43331 for ; Sat, 28 Mar 2020 23:01:07 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id 36DAD206F2 for ; Sat, 28 Mar 2020 23:01:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36DAD206F2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-18276-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 7887 invoked by uid 550); 28 Mar 2020 23:01:01 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 7867 invoked from network); 28 Mar 2020 23:01:01 -0000 Date: Sun, 29 Mar 2020 00:00:46 +0100 From: Alexey Gladkov To: Kees Cook Cc: LKML , Kernel Hardening , Linux API , Linux FS Devel , Linux Security Module , Akinobu Mita , Alexander Viro , Alexey Dobriyan , Andrew Morton , Andy Lutomirski , Daniel Micay , Djalal Harouni , "Dmitry V . Levin" , "Eric W . Biederman" , Greg Kroah-Hartman , Ingo Molnar , "J . Bruce Fields" , Jeff Layton , Jonathan Corbet , Linus Torvalds , Oleg Nesterov Subject: Re: [PATCH v10 7/9] proc: move hidepid values to uapi as they are user interface to mount Message-ID: <20200328230046.v3qbffmbtl4sd7tg@comp-core-i7-2640m-0182e6> References: <20200327172331.418878-1-gladkov.alexey@gmail.com> <20200327172331.418878-8-gladkov.alexey@gmail.com> <202003281340.B73225DCC9@keescook> <20200328212547.xxiqxqhxzwp6w5n5@comp-core-i7-2640m-0182e6> <202003281453.CED94974@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202003281453.CED94974@keescook> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.1 (raptor.unsafe.ru [5.9.43.93]); Sat, 28 Mar 2020 23:00:49 +0000 (UTC) On Sat, Mar 28, 2020 at 02:53:49PM -0700, Kees Cook wrote: > > > > +/* definitions for hide_pid field */ > > > > +enum { > > > > + HIDEPID_OFF = 0, > > > > + HIDEPID_NO_ACCESS = 1, > > > > + HIDEPID_INVISIBLE = 2, > > > > + HIDEPID_NOT_PTRACEABLE = 4, > > > > +}; > > > Should the numeric values still be UAPI if there is string parsing now? > > > > I think yes, because these are still valid hidepid= values. > > But if we don't expose the values, we can do whatever we like with > future numbers (e.g. the "is this a value or a bit field?" question). Alexey Dobriyan suggested to put these parameters into the UAPI and it makes sense because these are user parameters. -- Rgrds, legion