From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5D8FC43331 for ; Tue, 31 Mar 2020 12:37:59 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id 2DCE42072E for ; Tue, 31 Mar 2020 12:37:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="SaKeVZBv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2DCE42072E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-18333-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 5286 invoked by uid 550); 31 Mar 2020 12:37:52 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 5251 invoked from network); 31 Mar 2020 12:37:51 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585658259; bh=IaryMowmAx4OQ//gy52Bp04tanIU0UkHswH1YoJsT8E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SaKeVZBvfVFoEHqJLbz1ikyoWwc6oN2EtK2dgUPhBs6A7eMaJkcCkeBD7yR+BoTB+ fN9koCz2ZA7p2MxmDkCWzVoCO/sBcqKe+CKQ6JmvllaeOK/niJZL+dwRlPk/dWe6cW 7bUzAdVBKCwc7tuOdTp0doCxc05rTxTRMi7cl4qE= Date: Tue, 31 Mar 2020 13:37:34 +0100 From: Will Deacon To: "Paul E. McKenney" Cc: linux-kernel@vger.kernel.org, Eric Dumazet , Jann Horn , Kees Cook , Maddie Stone , Marco Elver , Peter Zijlstra , Thomas Gleixner , kernel-team@android.com, kernel-hardening@lists.openwall.com Subject: Re: [RFC PATCH 09/21] list: Remove unnecessary WRITE_ONCE() from hlist_bl_add_before() Message-ID: <20200331123733.GB30061@willie-the-truck> References: <20200324153643.15527-1-will@kernel.org> <20200324153643.15527-10-will@kernel.org> <20200330233020.GF19865@paulmck-ThinkPad-P72> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200330233020.GF19865@paulmck-ThinkPad-P72> User-Agent: Mutt/1.10.1 (2018-07-13) On Mon, Mar 30, 2020 at 04:30:20PM -0700, Paul E. McKenney wrote: > On Tue, Mar 24, 2020 at 03:36:31PM +0000, Will Deacon wrote: > > There is no need to use WRITE_ONCE() when inserting into a non-RCU > > protected list. > > > > Cc: Paul E. McKenney > > Cc: Peter Zijlstra > > Signed-off-by: Will Deacon > > OK, I will bite... Why "unsigned long" instead of "uintptr_t"? I just did that for consistency with the rest of the file, e.g. hlist_bl_first(), hlist_bl_set_first(), hlist_bl_empty() and __hlist_bl_del() all cast to 'unsigned long', yet only hlist_bl_add_before() was using 'uintptr_t' > Not that it matters in the context of the Linux kernel, so: > > Reviewed-by: Paul E. McKenney Thanks, Paul! Will