From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22A95C54FD0 for ; Mon, 20 Apr 2020 19:23:31 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id 785012084D for ; Mon, 20 Apr 2020 19:23:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 785012084D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-18575-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 26165 invoked by uid 550); 20 Apr 2020 19:23:22 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 26142 invoked from network); 20 Apr 2020 19:23:22 -0000 Date: Mon, 20 Apr 2020 15:23:06 -0400 From: Steven Rostedt To: Mark Rutland Cc: Peter Zijlstra , Sami Tolvanen , Will Deacon , Catalin Marinas , James Morse , Ard Biesheuvel , Masahiro Yamada , Michal Marek , Ingo Molnar , Juri Lelli , Vincent Guittot , Dave Martin , Kees Cook , Laura Abbott , Marc Zyngier , Masami Hiramatsu , Nick Desaulniers , Jann Horn , Miguel Ojeda , clang-built-linux@googlegroups.com, kernel-hardening@lists.openwall.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v11 04/12] scs: disable when function graph tracing is enabled Message-ID: <20200420152306.2d45e3c4@gandalf.local.home> In-Reply-To: <20200417154613.GB9529@lakrids.cambridge.arm.com> References: <20191018161033.261971-1-samitolvanen@google.com> <20200416161245.148813-1-samitolvanen@google.com> <20200416161245.148813-5-samitolvanen@google.com> <20200417100039.GS20730@hirez.programming.kicks-ass.net> <20200417144620.GA9529@lakrids.cambridge.arm.com> <20200417152645.GH20730@hirez.programming.kicks-ass.net> <20200417154613.GB9529@lakrids.cambridge.arm.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 17 Apr 2020 16:46:14 +0100 Mark Rutland wrote: > > > > And doesn't BPF also do stuff like this? > > > > > > Can BPF mess with return addresses now!? > > > > At least on x86 I think it does. But what do I know, I can't operate > > that stuff. Rostedt might know. > > Sounds like I might need to do some digging... May want to ping Alexei. It appears that if BPF adds a direct hook to a function, it will prevent the function graph tracer from tracing it. :-/ -- Steve