kernel-hardening.lists.openwall.com archive mirror
 help / color / mirror / Atom feed
* Kernel Self Protection Project: slub_debug=ZF
@ 2022-04-10 19:34 Peter Gerber
  2022-04-13  0:16 ` Kees Cook
  0 siblings, 1 reply; 2+ messages in thread
From: Peter Gerber @ 2022-04-10 19:34 UTC (permalink / raw)
  To: kernel-hardening; +Cc: linux-hardening

Hello,

The Kernel Self Protection Project, on their Recommended Settings [1] 
page, suggests the following:

# Enable SLUB redzoning and sanity checking (slow; requires 
CONFIG_SLUB_DEBUG=y above).
slub_debug=ZF

On recent kernels, I see the following in dmesg when this option is set:

**********************************************************
**   NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE   **
**                                                      **
** This system shows unhashed kernel memory addresses   **
** via the console, logs, and other interfaces. This    **
** might reduce the security of your system.            **
**                                                      **
** If you see this message and you are not debugging    **
** the kernel, report this immediately to your system   **
** administrator!                                       **
**                                                      **
**   NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE   **
**********************************************************

A bit of digging tells me that this is caused by "slub: force on 
no_hash_pointers when slub_debug is enabled" [2]. Assuming the 
performance impact is acceptable, is this option still recommend? Should 
there perhaps be a way to explicitly disable no_hash_pointers (e.g. via 
no_hash_pointers=off)?

Regards,

Peter

[1]: 
https://kernsec.org/wiki/index.php/Kernel_Self_Protection_Project/Recommended_Settings
[2]: 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=792702911f581f7793962fbeb99d5c3a1b28f4c3

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Kernel Self Protection Project: slub_debug=ZF
  2022-04-10 19:34 Kernel Self Protection Project: slub_debug=ZF Peter Gerber
@ 2022-04-13  0:16 ` Kees Cook
  0 siblings, 0 replies; 2+ messages in thread
From: Kees Cook @ 2022-04-13  0:16 UTC (permalink / raw)
  To: Peter Gerber; +Cc: kernel-hardening, linux-hardening

On Sun, Apr 10, 2022 at 09:34:17PM +0200, Peter Gerber wrote:
> Hello,
> 
> The Kernel Self Protection Project, on their Recommended Settings [1] page,
> suggests the following:
> 
> # Enable SLUB redzoning and sanity checking (slow; requires
> CONFIG_SLUB_DEBUG=y above).
> slub_debug=ZF
> 
> On recent kernels, I see the following in dmesg when this option is set:
> 
> **********************************************************
> **   NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE   **
> **                                                      **
> ** This system shows unhashed kernel memory addresses   **
> ** via the console, logs, and other interfaces. This    **
> ** might reduce the security of your system.            **
> **                                                      **
> ** If you see this message and you are not debugging    **
> ** the kernel, report this immediately to your system   **
> ** administrator!                                       **
> **                                                      **
> **   NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE   **
> **********************************************************
> 
> A bit of digging tells me that this is caused by "slub: force on
> no_hash_pointers when slub_debug is enabled" [2]. Assuming the performance
> impact is acceptable, is this option still recommend? Should there perhaps
> be a way to explicitly disable no_hash_pointers (e.g. via
> no_hash_pointers=off)?

Eww, that's not good at all. Would you be willing to write a patch to
decouple this again?

I think the primary issue is that these "debug" modes aren't exclusively
used for debugging, and exposing the unhashed pointer is directly in
conflict with the non-debug use case. :P

-Kees

> 
> Regards,
> 
> Peter
> 
> [1]: https://kernsec.org/wiki/index.php/Kernel_Self_Protection_Project/Recommended_Settings
> [2]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=792702911f581f7793962fbeb99d5c3a1b28f4c3

-- 
Kees Cook

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-04-13  0:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-10 19:34 Kernel Self Protection Project: slub_debug=ZF Peter Gerber
2022-04-13  0:16 ` Kees Cook

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).