From: Greg KH <gregkh@linuxfoundation.org>
To: "Hanno Böck" <hanno@hboeck.de>
Cc: kernel-hardening@lists.openwall.com
Subject: Re: [PATCH] Restrict access to TIOCLINUX
Date: Sun, 2 Apr 2023 19:23:44 +0200 [thread overview]
Message-ID: <2023040207-pretender-legislate-2e8b@gregkh> (raw)
In-Reply-To: <20230402191652.747b6acc.hanno@hboeck.de>
On Sun, Apr 02, 2023 at 07:16:52PM +0200, Hanno Böck wrote:
> On Sun, 2 Apr 2023 16:55:01 +0200
> Greg KH <gregkh@linuxfoundation.org> wrote:
>
> > You just now broke any normal user programs that required this (or the
> > other ioctls), and so you are going to have to force them to be run
> > with CAP_SYS_ADMIN permissions?
>
> Are you aware of such normal user programs?
> It was my impression that this is a relatively obscure feature and gpm
> is pretty much the only tool using it.
"Pretty much" does not mean "none" :(
> > And you didn't change anything for programs like gpm that already had
> > root permission (and shouldn't that permission be dropped anyway?)
>
> Well, you could restrict all that to a specific capability. However, it
> is my understanding that the existing capability system is limited in
> the number of capabilities and new ones should only be introduced in
> rare cases. It does not seem a feature probably few people use anyway
> deserves a new capability.
I did not suggest that a new capability be created for this, that would
be an abust of the capability levels for sure.
> Do you have other proposals how to fix this issue? One could introduce
> an option like for TIOCSTI that allows disabling selection features by
> default.
What exact issue are you trying to fix here?
thanks,
greg k-h
next prev parent reply other threads:[~2023-04-02 17:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-02 14:08 [PATCH] Restrict access to TIOCLINUX Hanno Böck
2023-04-02 14:55 ` Greg KH
2023-04-02 17:16 ` Hanno Böck
2023-04-02 17:23 ` Greg KH [this message]
2023-04-02 17:33 ` Hanno Böck
2023-04-02 17:44 ` Greg KH
2023-04-04 21:54 ` Jordan Glover
2023-08-18 16:10 ` Günther Noack
2023-08-22 12:07 ` Greg KH
2023-08-22 12:51 ` Boris Lukashev
2023-08-22 13:34 ` Greg KH
2023-08-22 18:22 ` Günther Noack
2023-08-23 14:36 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023040207-pretender-legislate-2e8b@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=hanno@hboeck.de \
--cc=kernel-hardening@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).